Satyajit Sahoo
d617ab82f9
chore: bump github scripts
2020-11-28 14:35:19 +01:00
Satyajit Sahoo
f5fd0e5be4
chore: add a label for first pull request
2020-11-28 14:33:19 +01:00
Satyajit Sahoo
7bef138e3d
chore: only count repro from user's github repos
2020-11-28 14:24:54 +01:00
Satyajit Sahoo
1406eb83ed
chore: publish
...
- @react-navigation/stack@5.12 .8
2020-11-21 05:32:53 +01:00
Satyajit Sahoo
3e069b718d
fix: force dismiss keyboard if there was no gesture
...
closes #9078
2020-11-21 05:32:00 +01:00
Satyajit Sahoo
7754eb450f
chore: publish
...
- @react-navigation/bottom-tabs@5.11 .2
- @react-navigation/compat@5.3.10
- @react-navigation/core@5.14 .4
- @react-navigation/devtools@5.1.18
- @react-navigation/drawer@5.11 .4
- @react-navigation/material-bottom-tabs@5.3.10
- @react-navigation/material-top-tabs@5.3.10
- @react-navigation/native@5.8.10
- @react-navigation/stack@5.12 .7
2020-11-20 18:07:07 +01:00
Satyajit Sahoo
95b2599877
fix: fix incorrect state change events in independent nested container
...
fixes #9080
2020-11-20 18:06:35 +01:00
Satyajit Sahoo
efcfa7121f
chore: only match repo links for GitHub in action
2020-11-20 12:03:50 +01:00
Satyajit Sahoo
a8e27ef448
chore: fix typo in github workflow
2020-11-16 15:33:46 +01:00
Satyajit Sahoo
946d2923d7
chore: publish
...
- @react-navigation/drawer@5.11 .3
2020-11-16 02:01:44 +01:00
Satyajit Sahoo
794339eeed
fix: hide drawer's header by default
2020-11-16 02:00:05 +01:00
Satyajit Sahoo
53141a6436
chore: add action to check for repro
2020-11-14 20:53:56 +01:00
Satyajit Sahoo
a2337648bf
chore: publish
...
- @react-navigation/bottom-tabs@5.11 .1
- @react-navigation/compat@5.3.9
- @react-navigation/core@5.14 .3
- @react-navigation/devtools@5.1.17
- @react-navigation/drawer@5.11 .2
- @react-navigation/material-bottom-tabs@5.3.9
- @react-navigation/material-top-tabs@5.3.9
- @react-navigation/native@5.8.9
- @react-navigation/stack@5.12 .6
2020-11-10 20:41:26 +01:00
Satyajit Sahoo
8f764d8b08
fix: improve the error message for incorrect screen configuration
2020-11-10 20:29:59 +01:00
Satyajit Sahoo
f8e998b10c
refactor: simplify getStateFromPath
2020-11-10 19:44:00 +01:00
Satyajit Sahoo
da35085f1e
fix: make sure inactive screen don't increase scroll area on web
2020-11-10 18:21:36 +01:00
Satyajit Sahoo
1f5fb5481a
chore: publish
...
- @react-navigation/drawer@5.11 .1
2020-11-09 20:40:11 +01:00
Satyajit Sahoo
18bbd177d9
fix: provide correct context to drawe header
2020-11-09 20:37:26 +01:00
Satyajit Sahoo
151055cf5a
chore: publish
...
- @react-navigation/bottom-tabs@5.11 .0
- @react-navigation/compat@5.3.8
- @react-navigation/core@5.14 .2
- @react-navigation/devtools@5.1.16
- @react-navigation/drawer@5.11 .0
- @react-navigation/material-bottom-tabs@5.3.8
- @react-navigation/material-top-tabs@5.3.8
- @react-navigation/native@5.8.8
- @react-navigation/routers@5.6.2
- @react-navigation/stack@5.12 .5
2020-11-09 20:17:39 +01:00
Satyajit Sahoo
52172453df
fix: try fixing drawer blink on Android
2020-11-09 20:05:27 +01:00
Satyajit Sahoo
7bc385e4f3
chore: show header in drawer by default
2020-11-09 19:36:36 +01:00
Satyajit Sahoo
6ac4d40140
feat: add a tabBarBadgeStyle option to customize the badge
2020-11-09 19:28:49 +01:00
Satyajit Sahoo
dbe961ba5b
feat: add option to show a header in drawer navigator screens
...
This commit adds new `header` and `headerShown` options in drawer navigator to be able to show a header, along with a bunch of header related options similar to stack navigator.
Historically, we have suggested to nest a stack navigator inside drawer navigator to render a header. While it works, it's not efficient to nest an entire navigator just for a header, considering it adds a lot of additional overhead from the code to handle animations, gestures etc. which won't ever be run in this case. It also increases the view hierarchy which has negative impacts on performance on Android, and could cause content not to render on older iOS devices.
Another issue with the approach is that since drawer navigator is at the root in this setup, it's possible to open drawer from every screen in the stack navigator, which usually isn't the expected behaviour. It's necessary to write additional code to disable the gesture to open drawer in all screens but first.
In addition, users also need to add a custom drawer icon to the header manually to be able to toggle the drawer
If drawer navigator could render its own header we'd avoid all these shortcomings as well as make the code simpler.
For now, I have implemented a new `Header` component in drawer since it's way simpler than stack navigator header. Though we may consider creating a shared UI package and add such components there which all our navigators could use.
The `Header` includes a button to toggle the drawer by default, and supports customization options such as showing custom left/right/title components. For this commit, I have kept `headerShown` to `false` by default coz I wasn't sure if it'd be a breaking change to start showing headers in drawers. Probably we can toggle it to `true` by default in next major.
2020-11-09 18:52:24 +01:00
Satyajit Sahoo
05d4e4d3be
refactor: minor tweak
2020-11-09 02:02:43 +01:00
Satyajit Sahoo
48b2e77730
fix: throw if the same pattern resolves to multiple screens
2020-11-09 01:56:30 +01:00
Satyajit Sahoo
e08c91ff0a
feat: add a hook to get bottom tab bar height
...
Usage:
```js
import { useBottomTabBarHeight } from '@react-navigation/stack';
// ...
const headerHeight = useBottomTabBarHeight();
```
closes #8037 , closes #8536
2020-11-08 20:08:50 +01:00
Satyajit Sahoo
5bd682f0bf
feat: add a getIsDrawerOpenFromState utility to drawer
2020-11-08 17:51:13 +01:00
Satyajit Sahoo
50a161dc3d
chore: publish
...
- @react-navigation/bottom-tabs@5.10 .7
- @react-navigation/compat@5.3.7
- @react-navigation/core@5.14 .1
- @react-navigation/devtools@5.1.15
- @react-navigation/drawer@5.10 .7
- @react-navigation/material-bottom-tabs@5.3.7
- @react-navigation/material-top-tabs@5.3.7
- @react-navigation/native@5.8.7
- @react-navigation/routers@5.6.1
- @react-navigation/stack@5.12 .4
2020-11-08 09:06:37 +01:00
Satyajit Sahoo
360b0e9958
fix: tweak error message when navigator has non-screen children
2020-11-07 16:43:45 +01:00
Satyajit Sahoo
e50c8aa942
refactor: use a regular action for 'resetRoot'
...
Previously, 'resetRoot' directly performed a 'setState' on the container instead of dispatching an action. This meant that hooks such as listener for 'preventRemove' won't be notified by it. This commit changes it to dispatch a regular 'RESET' action which will behave the same as other actions.
2020-11-07 15:55:48 +01:00
Satyajit Sahoo
8f0efc8db5
fix: don't hide child header automatically in stack
2020-11-07 14:39:23 +01:00
Satyajit Sahoo
7de6677e72
chore: fix statusbar height in modal example
2020-11-07 00:34:25 +01:00
Satyajit Sahoo
1dad338b7a
chore: publish
...
- @react-navigation/bottom-tabs@5.10 .6
- @react-navigation/compat@5.3.6
- @react-navigation/core@5.14 .0
- @react-navigation/devtools@5.1.14
- @react-navigation/drawer@5.10 .6
- @react-navigation/material-bottom-tabs@5.3.6
- @react-navigation/material-top-tabs@5.3.6
- @react-navigation/native@5.8.6
- @react-navigation/routers@5.6.0
- @react-navigation/stack@5.12 .3
2020-11-04 22:37:22 +01:00
Satyajit Sahoo
ce7d20e336
fix: disable react-native-screens on iOS for older versions
2020-11-04 22:36:43 +01:00
Satyajit Sahoo
e3e58c2d89
feat: add a NavigatorScreenParams type. closes #6931
2020-11-04 22:36:43 +01:00
Satyajit Sahoo
cb2e744dce
fix: always respect key in the route object when generating action
2020-11-04 22:36:43 +01:00
Satyajit Sahoo
9beca3a802
feat: add a merge option to navigate to control merging params
2020-11-04 22:36:43 +01:00
Satyajit Sahoo
ec7b02af2c
feat: add warning on accessing the state object on route prop
2020-11-04 22:36:43 +01:00
Satyajit Sahoo
4c2379cec1
fix: ignore any errors from deep linking
2020-11-04 22:36:43 +01:00
marhaupe
1169ed0946
fix: android textinput gets blurred after navigating back
...
When navigating from ScreenA to ScreenB and then back to ScreenA,
react-navigation unconditionally calls `Keyboard.dismiss()`.
If the user is fast enough and taps on a `TextInput` after coming
back from ScreenB, the keyboard opens, just to be dismissed again.
This would also happen if some logic automatically focuses the
`TextInput` in ScreenA. This behaviour can be seen observed in
https://snack.expo.io/lTDZhVNhV .
2020-11-04 22:35:57 +01:00
Satyajit Sahoo
bf464a8378
chore: tweak workflows for triage
2020-11-04 14:23:46 +01:00
Satyajit Sahoo
a495506e20
chore: publish
...
- @react-navigation/bottom-tabs@5.10 .5
- @react-navigation/compat@5.3.5
- @react-navigation/core@5.13 .5
- @react-navigation/devtools@5.1.13
- @react-navigation/drawer@5.10 .5
- @react-navigation/material-bottom-tabs@5.3.5
- @react-navigation/material-top-tabs@5.3.5
- @react-navigation/native@5.8.5
- @react-navigation/stack@5.12 .2
2020-11-04 13:24:15 +01:00
Satyajit Sahoo
b20f2d1f7c
fix: use useDebugValue in more places
2020-11-04 13:21:36 +01:00
Satyajit Sahoo
66f3a4a0bb
fix: don't use use-subscription to avoid peer dep related errors
...
The `use-subscription` package has a peer dep on latest React. This is problematic when using npm due to it's peer dependency algorithm which installs multiple versions of React when using an older version of React (Native).
This means that we'll need to use an ancient version of `use-subscription` to support older React versions with npm and make sure to never update it, or test with every version.
It's much lower maintenance to incporporate the same update in render logic that `use-subscription` has and not deal with dependencies. So this commit removes the `use-subscription` dependency.
See https://github.com/react-navigation/react-navigation/issues/9021#issuecomment-721679760 for more context.
2020-11-04 13:06:49 +01:00
Satyajit Sahoo
84cc0d758a
chore: publish
...
- @react-navigation/bottom-tabs@5.10 .4
- @react-navigation/compat@5.3.4
- @react-navigation/core@5.13 .4
- @react-navigation/devtools@5.1.12
- @react-navigation/drawer@5.10 .4
- @react-navigation/material-bottom-tabs@5.3.4
- @react-navigation/material-top-tabs@5.3.4
- @react-navigation/native@5.8.4
- @react-navigation/stack@5.12 .1
2020-11-03 07:04:08 +01:00
Satyajit Sahoo
ebc7f9ea75
fix: fix nested navigation not working the first time
2020-11-03 06:59:42 +01:00
Satyajit Sahoo
bd9f0ad5f6
chore: publish
...
- @react-navigation/bottom-tabs@5.10 .3
- @react-navigation/compat@5.3.3
- @react-navigation/core@5.13 .3
- @react-navigation/devtools@5.1.11
- @react-navigation/drawer@5.10 .3
- @react-navigation/material-bottom-tabs@5.3.3
- @react-navigation/material-top-tabs@5.3.3
- @react-navigation/native@5.8.3
- @react-navigation/stack@5.12 .0
2020-11-03 06:31:58 +01:00
Satyajit Sahoo
c326c106f9
feat: add a headerBackAccessibilityLabel option in stack
...
closes #9016
2020-11-03 06:22:51 +01:00
Satyajit Sahoo
52451d1109
fix: make sure that invalid linking config doesn't work if app is open
2020-11-03 06:15:44 +01:00
Satyajit Sahoo
0945689b70
fix: handle navigating to same screen again for nested screens
2020-11-03 05:51:52 +01:00
