kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-02 22:41:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use markUpdated instead of dirty setPadding in nodes

Browse Source 
Summary: setPadding already calls dirty, and we should only be calling dirty on nodes that have measure functions.

Reviewed By: emilsjolander

Differential Revision: D4205148
This commit is contained in:
Andy Street
2016-11-18 10:25:20 -08:00
committed by Ahmed El-Helw
parent 1d555bff22
commit bb8d540cf7
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ReactAndroid/src/main/java/com/facebook/react/flat/FlatARTSurfaceViewShadowNode.java
View File

@@ -106,7 +106,7 @@ import com.facebook.react.views.art.ARTVirtualNode;
if (getPadding(spacingType) != padding) {
super.setPadding(spacingType, padding);
mPaddingChanged = true;
dirty();
markUpdated();
}
}

2
ReactAndroid/src/main/java/com/facebook/react/flat/FlatReactModalShadowNode.java
View File

@@ -89,7 +89,7 @@ class FlatReactModalShadowNode extends FlatShadowNode implements AndroidView {
if (getPadding(spacingType) != padding) {
super.setPadding(spacingType, padding);
mPaddingChanged = true;
dirty();
markUpdated();
}
}
}

2
ReactAndroid/src/main/java/com/facebook/react/flat/NativeViewWrapper.java
View File

@@ -104,7 +104,7 @@ import com.facebook.react.uimanager.ViewManager;
if (getPadding(spacingType) != padding) {
super.setPadding(spacingType, padding);
mPaddingChanged = true;
dirty();
markUpdated();
}
}