From bb8d540cf75529871ffa4883fdcc8b96dd3edf67 Mon Sep 17 00:00:00 2001 From: Andy Street Date: Fri, 18 Nov 2016 10:25:20 -0800 Subject: [PATCH] Use markUpdated instead of dirty setPadding in nodes Summary: setPadding already calls dirty, and we should only be calling dirty on nodes that have measure functions. Reviewed By: emilsjolander Differential Revision: D4205148 --- .../com/facebook/react/flat/FlatARTSurfaceViewShadowNode.java | 2 +- .../java/com/facebook/react/flat/FlatReactModalShadowNode.java | 2 +- .../main/java/com/facebook/react/flat/NativeViewWrapper.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatARTSurfaceViewShadowNode.java b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatARTSurfaceViewShadowNode.java index 5f997352b..139eb6269 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatARTSurfaceViewShadowNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatARTSurfaceViewShadowNode.java @@ -106,7 +106,7 @@ import com.facebook.react.views.art.ARTVirtualNode; if (getPadding(spacingType) != padding) { super.setPadding(spacingType, padding); mPaddingChanged = true; - dirty(); + markUpdated(); } } diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatReactModalShadowNode.java b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatReactModalShadowNode.java index f2ea116d1..043ed1260 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatReactModalShadowNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatReactModalShadowNode.java @@ -89,7 +89,7 @@ class FlatReactModalShadowNode extends FlatShadowNode implements AndroidView { if (getPadding(spacingType) != padding) { super.setPadding(spacingType, padding); mPaddingChanged = true; - dirty(); + markUpdated(); } } } diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/NativeViewWrapper.java b/ReactAndroid/src/main/java/com/facebook/react/flat/NativeViewWrapper.java index f8708d24f..83d8625bc 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/NativeViewWrapper.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/NativeViewWrapper.java @@ -104,7 +104,7 @@ import com.facebook.react.uimanager.ViewManager; if (getPadding(spacingType) != padding) { super.setPadding(spacingType, padding); mPaddingChanged = true; - dirty(); + markUpdated(); } }