kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-01-12 22:50:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Re-enable testBundleURL test in open source

Browse Source 
Summary:
The `testBundleURL` test was disabled in open source recently due to issues running it successfully in Facebook's internal CI. We're now skipping `RCTBundleURLProviderTests` tests internally, so it's safe to re-enable now and ensure it runs in Circle CI.

Changelog:

[iOS] [Changed] - Re-enable testBundleURL unit test.

Reviewed By: cpojer

Differential Revision: D15140192

fbshipit-source-id: 5f6a91f3ce8cea245be31dff3ffb86768deab0be
This commit is contained in:
Héctor Ramos
2019-04-30 09:44:00 -07:00
committed by Facebook Github Bot
parent 49d26eb0c4
commit 005b4556ce
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
RNTester/RNTesterUnitTests/RCTBundleURLProviderTests.m
View File

@@ -71,10 +71,8 @@ static NSURL *ipBundleURL()
NSURL *URL = [settings jsBundleURLForBundleRoot:testFile fallbackResource:nil];
if (!getenv("CI_USE_PACKAGER")) {
XCTAssertEqualObjects(URL, mainBundleURL());
// TODO: t43430850: Temporarily disable testBundleURL test.
// To be re-enabled when the packager can be reliably used on Sandcastle.
// } else {
// XCTAssertEqualObjects(URL, localhostBundleURL());
} else {
XCTAssertEqualObjects(URL, localhostBundleURL());
}
}