From 005b4556ce3e655a9e6dad3b8e99583bd4b2b235 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9ctor=20Ramos?= Date: Tue, 30 Apr 2019 09:44:00 -0700 Subject: [PATCH] Re-enable testBundleURL test in open source Summary: The `testBundleURL` test was disabled in open source recently due to issues running it successfully in Facebook's internal CI. We're now skipping `RCTBundleURLProviderTests` tests internally, so it's safe to re-enable now and ensure it runs in Circle CI. Changelog: [iOS] [Changed] - Re-enable testBundleURL unit test. Reviewed By: cpojer Differential Revision: D15140192 fbshipit-source-id: 5f6a91f3ce8cea245be31dff3ffb86768deab0be --- RNTester/RNTesterUnitTests/RCTBundleURLProviderTests.m | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/RNTester/RNTesterUnitTests/RCTBundleURLProviderTests.m b/RNTester/RNTesterUnitTests/RCTBundleURLProviderTests.m index 89585a5f0..b1f7c204c 100644 --- a/RNTester/RNTesterUnitTests/RCTBundleURLProviderTests.m +++ b/RNTester/RNTesterUnitTests/RCTBundleURLProviderTests.m @@ -71,10 +71,8 @@ static NSURL *ipBundleURL() NSURL *URL = [settings jsBundleURLForBundleRoot:testFile fallbackResource:nil]; if (!getenv("CI_USE_PACKAGER")) { XCTAssertEqualObjects(URL, mainBundleURL()); - // TODO: t43430850: Temporarily disable testBundleURL test. - // To be re-enabled when the packager can be reliably used on Sandcastle. - // } else { - // XCTAssertEqualObjects(URL, localhostBundleURL()); + } else { + XCTAssertEqualObjects(URL, localhostBundleURL()); } }