Commit Graph

288 Commits

Author SHA1 Message Date
Alessandro (Ale) Segala
fdbb55022c InlineChunkHtmlPlugin works with empty publicPath (#6735)
* InlineChunkHtmlPlugin works with empty publicPath

* Update as requested
2019-04-15 20:38:31 -06:00
Ian Schmitz
91ddd618be Update dependency versions (#6767)
Includes only minor/patch version bumps.
2019-04-06 15:16:08 -07:00
Tom Crockett
c03d6b17dc Update fork-ts-checker-webpack-plugin out of alpha (#6739)
<!--
Thank you for sending the PR!

If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots!

Happy contributing!
-->
2019-04-06 14:00:46 -07:00
Ian Schmitz
76fea02277 Cleanup Jest config (#6654)
General cleanup after the [Jest 24 PR](#6278). 

This also includes `jsdom@14` via https://www.npmjs.com/package/jest-environment-jsdom-fourteen. Since we have a node >= 8.10 requirement, we are able to use the latest version of `jsdom` which includes additional implementations of browser APIs such as `MutationObserver` (which we had an issue filed for over at #6617).

/cc @SimenB. Is there more you recommend we do to cleanup our [Jest config](b0cbf2caa1/packages/react-scripts/scripts/utils/createJestConfig.js) for TypeScript?

Co-authored-by: Ian Sutherland <ian@iansutherland.ca>
2019-04-04 11:00:00 -06:00
Mohit Singh
8175f1e418 Remove unused eslint comment (#6674) 2019-03-18 07:25:31 -07:00
W1lkins
7864ba3ce7 Add wait: false when opening app in browser (#5821) 2019-03-15 13:48:55 -06:00
Lorenzo Rapetti
3be3576304 Update to Jest 24 (#6278)
* Update to jest 24

* Add notice about pnpResolver.js

* Formatting

* Fix linting

* Update to jest 24.1.0

* Update jest-pnp-resolver

* Swap create-react-app params in e2e scripts

* Add extraGlobals to supportedKeys

* Bump jest to 24.3.1

* Bump jest to 24.4.0

* Bumb jest to 24.5.0

* Update template dependencies jest to 24.5.0

* Debug failing test

* Remove jest-pnp-resolver

* Remove console.log

* Revert yarn.lock.cached
2019-03-15 12:02:59 -06:00
Ian Schmitz
f4f20a20d0 Support browserslist in @babel/preset-env (#6608)
* Add browserslist support to @babel/preset-env

* Support @babel/polyfill in entry point
2019-03-14 12:16:09 -07:00
Ian Schmitz
3c9c21a285 Upgrade dependencies (#6614)
* Upgrade dependencies

* Upgrade a couple missed deps

* Run Prettier over codebase
2019-03-11 20:45:14 -06:00
John Reilly
bac02873eb Enable click to go to error in console for TypeScript (#6502)
* reattempt changes

* formatter fixes

* fix missing colon in path

* revert path tweaking amends as per discussion with @ianschmitz
2019-03-10 09:31:30 -07:00
Ian Sutherland
c17e25bf7f Publish
- create-react-app@2.1.8
 - react-dev-utils@8.0.0
 - react-scripts@2.1.8
2019-03-06 17:53:30 -07:00
Ian Sutherland
1548a0a92e Reapply "Speed up TypeScript v2 (#6406)" (#6586)
This reverts commit b2cf28b7f1 and reapplies #6406.
2019-03-06 17:46:38 -07:00
Ian Sutherland
e69ad37fcf Publish
- create-react-app@2.1.7
 - react-dev-utils@7.0.5
 - react-scripts@2.1.7
2019-03-06 17:40:34 -07:00
Ian Sutherland
b2cf28b7f1 Revert "Speed up TypeScript v2 (#6406)" (#6585)
This reverts commit 6a5b3cdaaa.
2019-03-06 17:33:17 -07:00
Ian Sutherland
b5887dcac7 Publish
- babel-preset-react-app@7.0.2
 - confusing-browser-globals@1.0.6
 - create-react-app@2.1.6
 - eslint-config-react-app@3.0.8
 - react-app-polyfill@0.2.2
 - react-dev-utils@7.0.4
 - react-error-overlay@5.1.4
 - react-scripts@2.1.6
2019-03-06 16:17:21 -07:00
Bimochan Shrestha
ff19e0a6d2 Fix build deployment instruction link appends comma at end (#6511) 2019-02-24 14:45:06 -08:00
Matt Wood
38ae7348c8 minor typo fix in openBrowser 2019-02-21 09:40:00 -06:00
Leigh Halliday
d57fd37d2d Convert all bit.ly links from http to https (#6239) 2019-02-19 09:25:19 -07:00
Ian Schmitz
6a5b3cdaaa Speed up TypeScript v2 (#6406)
* Revert "Revert "Speed up TypeScript projects (#5903)""

This reverts commit 544a5943ce.

* Move fork-ts-checker dep to react-dev-utils

* Convert WebpackDevServerUtils.createCompiler to take in options arg

* Update README.md for react-dev-utils
2019-02-18 16:31:44 -08:00
Ian Schmitz
1548e39bf7 Publish
- create-react-app@2.1.5
 - react-dev-utils@7.0.3
 - react-scripts@2.1.5
2019-02-11 08:36:54 -08:00
Ian Schmitz
544a5943ce Revert "Speed up TypeScript projects (#5903)"
This reverts commit 5ce09db2b3.
2019-02-11 08:10:33 -08:00
Ian Schmitz
72c49ac807 Revert "Move fork-ts-checker-webpack-plugin dependency to react-dev-utils (#6395)"
This reverts commit c2b715847c.
2019-02-11 08:10:10 -08:00
X.L
c2b715847c Move fork-ts-checker-webpack-plugin dependency to react-dev-utils (#6395) 2019-02-11 07:41:55 -08:00
Ian Schmitz
b02f181d0d Publish
- babel-plugin-named-asset-import@0.3.1
 - babel-preset-react-app@7.0.1
 - create-react-app@2.1.4
 - eslint-config-react-app@3.0.7
 - react-app-polyfill@0.2.1
 - react-dev-utils@7.0.2
 - react-error-overlay@5.1.3
 - react-scripts@2.1.4
2019-02-10 13:48:33 -08:00
Ian Schmitz
b7e0158441 Upgrade dependencies (#6393) 2019-02-10 12:24:40 -08:00
Tomáš Szabo
5ce09db2b3 Speed up TypeScript projects (#5903)
As a lot of [people](https://hackernoon.com/why-i-no-longer-use-typescript-with-react-and-why-you-shouldnt-either-e744d27452b4) is complaining about TypeScript performance in CRA, I decided to enable `async` mode in TypeScript checker.

These changes basically brings the JS compilation times to TS projects. So, recompilation took less than 1 second instead of 3 seconds in medium size project.

The problem with async mode is that type-errors are reported after Webpack ends up recompilation as TypeScript could be slower than Babel. PR allows to emit files compiled by Babel immediately and then wait for TS and show type errors in terminal later. Also, if there was no compilation errors and any type error occurs, we trigger a hot-reload with new errors to show error overlay in browser.

Also, I wanted to start a discussion about `skipLibCheck: false` option in default `tsconfig.json`. This makes recompilations really slow and we should consider to set it to `true` or at least give users a big warning to let them know that it could be really slow.

The following video is showing the updated workflow with a forced 2.5 second delay for type-check to give you an idea how it works.

![nov-26-2018 15-47-01](https://user-images.githubusercontent.com/5549148/49021284-9446fe80-f192-11e8-952b-8f83d77d5fbc.gif)


I'm pretty sure that PR needs some polishing and improvements but it should works as it is. Especially a "hack" with reloading the browser after type-check looks ugly to me.

cc @brunolemos as he is an initiator of an original TypeScript PR.

Should fix https://github.com/facebook/create-react-app/issues/5820
2019-02-07 19:34:52 -08:00
Otávio Pace
47e9e2c7a0 Move chalk dependency to react-dev-utils (#6150)
Related to #751
2019-01-12 13:55:57 +02:00
David Rice
6e261f8a06 Update react-dev-util globby dependency to v8.0.2 (#6162)
v8.0.2 was recently released https://github.com/sindresorhus/globby/releases to fix some pathing issues with dir-glob.
2019-01-09 14:24:03 -05:00
Joe Haddad
3e1dc99013 Fix CI and upgrade dependencies (#6137)
* Upgrade a bunch of dependencies

* Turn off nightly Yarn
2019-01-06 13:13:20 -05:00
Ian Schmitz
0d0d0349a5 Publish
- create-react-app@2.1.3
 - react-dev-utils@7.0.1
 - react-error-overlay@5.1.2
 - react-scripts@2.1.3
2019-01-04 10:53:44 -08:00
Joe Haddad
d7c0b59242 Publish
- babel-plugin-named-asset-import@0.3.0
 - babel-preset-react-app@7.0.0
 - create-react-app@2.1.2
 - eslint-config-react-app@3.0.6
 - react-app-polyfill@0.2.0
 - react-dev-utils@7.0.0
 - react-error-overlay@5.1.1
 - react-scripts@2.1.2
2018-12-23 13:53:12 -05:00
Ian Sutherland
7513481491 Update links to docs in all package README files (#5912)
* Update links to docs in all package README files

* Fix formatting of issue template

* Fix formatting of issue template
2018-12-06 13:30:54 -07:00
Michael Jackson
4878f2cae7 Correct some comments (#5927)
And remove some outdated info from 1.x
2018-11-29 20:48:07 -08:00
Simen Bekkhus
3a14e8fc26 fix: make typescriptformatter support 0.5 of fork checker (#5879) 2018-11-22 20:44:35 -05:00
Joe Haddad
3e9ba54018 Publish
- babel-plugin-named-asset-import@0.2.3
 - babel-preset-react-app@6.1.0
 - create-react-app@2.1.1
 - react-dev-utils@6.1.1
 - react-error-overlay@5.1.0
 - react-scripts@2.1.1
2018-10-31 23:29:52 -04:00
Joe Haddad
b8c180dca3 Publish
- babel-preset-react-app@6.0.0
 - confusing-browser-globals@1.0.5
 - create-react-app@2.1.0
 - eslint-config-react-app@3.0.5
 - react-dev-utils@6.1.0
 - react-error-overlay@5.0.6
 - react-scripts@2.1.0
2018-10-29 23:40:56 -04:00
Joe Haddad
5ead915b73 Automatically setup TypeScript when detected (#5549)
* Don't resolve TS files if it's not detected in the project

* Automatically create tsconfig.json file for user

* Remove always false check

* Add missing file

* Don't filter paths too early
2018-10-24 00:59:26 -04:00
Ian Schmitz
315ff4b487 Respect tsconfig.json extends when validating config (#5537)
* Use TS to resolve tsconfig extends

* Prevent modifications to original tsconfig

* Print friendly error
2018-10-23 15:52:48 -04:00
Joe Haddad
5410da0bfc Add TypeScript error formatting (#5529) 2018-10-22 13:29:18 -04:00
Dan Abramov
f89385f743 Publish
- babel-preset-react-app@5.0.4
 - confusing-browser-globals@1.0.4
 - create-react-app@2.0.4
 - eslint-config-react-app@3.0.4
 - react-dev-utils@6.0.5
 - react-error-overlay@5.0.5
 - react-scripts@2.0.5
2018-10-14 20:03:15 +01:00
Dan Abramov
bd0ffb72aa Fix click-to-open on Windows (#5431)
* Fix click-to-open on Windows

* Oops
2018-10-14 19:27:34 +01:00
Oskar Persson
9fd98447d8 Fix file size report after build (#5335)
Fixes #5333

printFileSizesAfterBuild calls canReadAsset with an object containing
the file name while measureFileSizesBeforeBuild calls it with just the
name. When canReadAsset only receives the name it returns false since
accessing the `name` property results in undefined.

This commit fixes that by having canReadAssset instead expect only the
file name and making printFileSizesAfterBuild just like
measureFileSizesBeforeBuild only provide the name as argument.
2018-10-06 18:27:30 -04:00
Joe Haddad
6e14dbbbb8 Publish
- babel-preset-react-app@5.0.3
 - create-react-app@2.0.3
 - react-dev-utils@6.0.4
 - react-error-overlay@5.0.4
 - react-scripts@2.0.4
2018-10-03 16:01:44 -04:00
Joe Haddad
209053b97e Publish
- babel-plugin-named-asset-import@0.2.2
 - babel-preset-react-app@5.0.2
 - confusing-browser-globals@1.0.3
 - create-react-app@2.0.2
 - eslint-config-react-app@3.0.3
 - react-app-polyfill@0.1.3
 - react-dev-utils@6.0.3
 - react-error-overlay@5.0.3
 - react-scripts@2.0.3
2018-10-01 20:54:45 -04:00
Irvin Denzel Torcuato
bf5a4bf989 Feed correct line number to gvim on launch (#5202)
Clicking Error overlay should feed the correct line number for gvim.

Added `gvim` in `COMMON_EDITORS_LINUX`, launches new gvim when it is running.

Tested with gvim 8.0.707 on a Debian 4.9.110-3+deb9u4 (2018-08-21) x86_64 GNU/Linux VM

Relates to https://github.com/facebook/create-react-app/issues/2636.
2018-10-01 22:08:53 +01:00
Joe Haddad
f0784fc27f Publish
- babel-plugin-named-asset-import@0.2.1
 - babel-preset-react-app@5.0.1
 - confusing-browser-globals@1.0.2
 - create-react-app@2.0.1
 - eslint-config-react-app@3.0.1
 - react-app-polyfill@0.1.2
 - react-dev-utils@6.0.2
 - react-error-overlay@5.0.2
 - react-scripts@2.0.2
2018-10-01 12:21:46 -04:00
Joe Haddad
2afcd4fdfc Add license file to all packages (#5192) 2018-09-30 23:17:18 -04:00
Joe Haddad
789933c0aa Still emit runtime chunk (#5184) 2018-09-30 20:58:45 -04:00
Joe Haddad
7b1a32be6e Polish webpack message output (#5174)
* Only install react-scripts in CI mode

* Link locally

* Re-enable all output tests

* 💄 Polish webpack output

* Test sass support message

* Add more tests, but disabled

* Format missing default export error

* Format aliased import

* Why was node-sass required? Odd

* Format webpack rejection error

* Re-enable unknown package test

* Format file not found error and catch module scope plugin error

* Re-disable case sensitive paths

* Intercept and format case sensitive path errors

* Test out of scope message formatting

* Run behavior on macOS

* Run behavior on Node 8 and 10, only Node 8 for macOS

* Add some debugging

* Update matcher

* Only check stderr

* Remove old snapshot

* More debug

* Remove debug

* Add new debug

* Disable test on linux

* Add comment for future
2018-09-30 17:44:49 -04:00
Joe Haddad
401ff540e4 Filter out precache assets 2018-09-28 23:25:27 -04:00