Correct some comments (#5927)

And remove some outdated info from 1.x
This commit is contained in:
Michael Jackson
2018-11-29 20:48:07 -08:00
committed by Ian Schmitz
parent 5352a0c046
commit 4878f2cae7

View File

@@ -269,8 +269,6 @@ function onProxyError(proxy) {
function prepareProxy(proxy, appPublicFolder) {
// `proxy` lets you specify alternate servers for specific requests.
// It can either be a string or an object conforming to the Webpack dev server proxy configuration
// https://webpack.github.io/docs/webpack-dev-server.html
if (!proxy) {
return undefined;
}
@@ -287,7 +285,7 @@ function prepareProxy(proxy, appPublicFolder) {
process.exit(1);
}
// Otherwise, if proxy is specified, we will let it handle any request except for files in the public folder.
// If proxy is specified, let it handle any request except for files in the public folder.
function mayProxy(pathname) {
const maybePublicPath = path.resolve(appPublicFolder, pathname.slice(1));
return !fs.existsSync(maybePublicPath);
@@ -321,7 +319,7 @@ function prepareProxy(proxy, appPublicFolder) {
// For `GET` requests, if request `accept`s text/html, we pick /index.html.
// Modern browsers include text/html into `accept` header when navigating.
// However API calls like `fetch()` wont generally accept text/html.
// If this heuristic doesnt work well for you, use a custom `proxy` object.
// If this heuristic doesnt work well for you, use `src/setupProxy.js`.
context: function(pathname, req) {
return (
req.method !== 'GET' ||
@@ -331,7 +329,7 @@ function prepareProxy(proxy, appPublicFolder) {
);
},
onProxyReq: proxyReq => {
// Browers may send Origin headers even with same-origin
// Browsers may send Origin headers even with same-origin
// requests. To prevent CORS issues, we have to change
// the Origin to match the target URL.
if (proxyReq.getHeader('origin')) {