mirror of
https://github.com/zhigang1992/create-react-app.git
synced 2026-04-26 14:15:50 +08:00
Feed correct line number to gvim on launch (#5202)
Clicking Error overlay should feed the correct line number for gvim. Added `gvim` in `COMMON_EDITORS_LINUX`, launches new gvim when it is running. Tested with gvim 8.0.707 on a Debian 4.9.110-3+deb9u4 (2018-08-21) x86_64 GNU/Linux VM Relates to https://github.com/facebook/create-react-app/issues/2636.
This commit is contained in:
committed by
Dan Abramov
parent
b10337697e
commit
bf5a4bf989
2
packages/react-dev-utils/launchEditor.js
vendored
2
packages/react-dev-utils/launchEditor.js
vendored
@@ -67,6 +67,7 @@ const COMMON_EDITORS_LINUX = {
|
||||
code: 'code',
|
||||
'code-insiders': 'code-insiders',
|
||||
emacs: 'emacs',
|
||||
gvim: 'gvim',
|
||||
'idea.sh': 'idea',
|
||||
'phpstorm.sh': 'phpstorm',
|
||||
'pycharm.sh': 'pycharm',
|
||||
@@ -136,6 +137,7 @@ function getArgumentsForLineNumber(
|
||||
case 'vim':
|
||||
case 'mvim':
|
||||
case 'joe':
|
||||
case 'gvim':
|
||||
return ['+' + lineNumber, fileName];
|
||||
case 'emacs':
|
||||
case 'emacsclient':
|
||||
|
||||
Reference in New Issue
Block a user