kylefang/angular.js
1
0
Fork 0
mirror of https://github.com/zhigang1992/angular.js.git synced 2026-04-01 12:33:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(angular.copy): throw Error if source and destination are identical

Browse Source 
Closes #693
This commit is contained in:
Dhruv Manek
2011-12-18 18:33:25 -08:00
committed by Igor Minar
parent 0bf611087b
commit 08029c7b72
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/Angular.js
View File

@@ -597,6 +597,7 @@ function copy(source, destination){
}
}
} else {
if (source === destination) throw Error("Can't copy equivalent objects or arrays");
if (isArray(source)) {
while(destination.length) {
destination.pop();

8
test/AngularSpec.js
View File

@@ -65,6 +65,14 @@ describe('angular', function() {
it('should throw an exception if a Window is being copied', function() {
expect(function() { copy(window); }).toThrow("Can't copy Window or Scope");
});
it('should throw an exception when source and destination are equivalent', function() {
var src, dst;
src = dst = {key: 'value'};
expect(function() { copy(src, dst); }).toThrow("Can't copy equivalent objects or arrays");
src = dst = [2, 4];
expect(function() { copy(src, dst); }).toThrow("Can't copy equivalent objects or arrays");
});
});
describe('equals', function() {