kylefang/GitHawk
1
0
Fork 0
mirror of https://github.com/zhigang1992/GitHawk.git synced 2026-05-28 06:36:05 +08:00
Code Issues Packages Projects Releases Wiki Activity
1,524 Commits 11 Branches 14 Tags
e87df7e3c1221f147fe506d145d75dd070c4d1aa
Commit Graph

81 Commits

Author SHA1 Message Date
Joan Disho
e87df7e3c1 make IssueCommentSectionController conform to MarkdownStyledTextViewDelegate (#1718) 2018-04-10 09:58:04 -04:00
Joan Disho
641d7e6cc3 refactor the code 2018-04-10 11:42:52 +02:00
Joan Disho
96be2d1ad8 remove "import MessageViewController" from IssueCommentSectionController 2018-04-10 11:42:52 +02:00
Joan Disho
eab6797d47 quote a substring of the comment and mention the user in messageView on reply. 2018-04-10 11:42:52 +02:00
Joan Disho
b0fefae3ab focus on the comment on reply action 2018-04-10 11:42:52 +02:00
Joan Disho
2a7664968b make messageView firstResponder onReply action 2018-04-10 11:42:52 +02:00
Joan Disho
e53d954b7b add Reply action on didTapMore(cell: sender:) 2018-04-10 11:41:53 +02:00
Ryan Nystrom
62e2763a85 Refactor markdown parsing to use text lib (#1674) 
* milestones refactored with styled text

* reference refactored

* refactor commit references

* fix styled text bug

* request event refactored

* refactor titles

* warm caches for bg-gen models

* delete old text cell

* move shortlinks into MMMarkdown

* almost there

* build green

* running and trimming whitespaces

* styled text working

* fix tests

* tests passing
 2018-03-31 10:12:51 -04:00
Luciano Almeida
84d39ddab8 Fixing overlap content after react menu on comment. (#1577) 
* Fixing overlap content after react menu.

* more elegant solution for the fix. :))
 2018-03-21 21:38:38 -04:00
Ryan Nystrom
66dc61ace0 Refactor labeled events to use StyledText (#1659) 
* refactor tap handling on attributed views

* styled cell interaction working

* share menu code

* label events finished
 2018-03-18 14:55:57 -04:00
Ryan Nystrom
45335eb4a0 [WIP] Refactor networking to shared lib (#1602) 
* [WIP] Refactor networking to shared lib

* notification models as codable and tests

* default request params

* break out into files

* fix tests

* check notification values

* add milestones

* add milestone response

* repo notifications

* refactor v3 response

* refactor to support passing response to response initializer

* add release fetch and model

* add examples from githawk

* notifications working

* almost all notifications requests migrated

* finish notification migration, add graphql request/response

* replace issue requests

* replace milestones request

* fetch assignees migrated

* readme fetch migrated

* migrate badge request

* delete unused request from client

* remove paging

* nearly done w/ migration

* local build green

* refactor gql fetches, replace mutations

* build green, slim down client

* strip session manager from client

* everything working
 2018-03-04 21:35:36 -05:00
Ryan Nystrom
db21d4debe disable uncollapse when menu visible (#1413) 2018-01-14 12:12:03 -05:00
Ryan Nystrom
878a9d98b7 refactor collapse cells (#1406) 2018-01-13 17:21:55 -05:00
Ryan Nystrom
65959c7c14 Card inset design completely overhauled (#1396) 
* card inset design completely overhauled

* respond to safe area changes
 2018-01-13 12:37:00 -05:00
Ryan Nystrom
6b7c9f1bfa properly present VC from reference events (#1363) 2018-01-05 22:29:49 -05:00
Ryan Nystrom
755be5af2e Refactor autocomplete control and wire it up in comment editing (#1326) 
* refactor text view delegate to be 1:many

* move autocomplete stuff to its own controller + API

* refactor VC to work with new autocomplete controller

* update pods with new message stuff

* reorganize and fixup files

* app builds

* better names

* thread autocomplete to comment SC

* autocomplete working in edit

* finish refactor
 2018-01-02 09:14:28 -05:00
Ryan Nystrom
167f1b80fe Redesign issue comments with a card (#1320) 
* Redesign issue comments with a card

* fix more button, content view layout

* finish polishing card layout
 2017-12-31 12:37:19 -05:00
Bas Broek
377161aed0 Fix Int format crash + unify String localization (#1273) 
* Use %d over %zi to prevent a possible crash

* Clean up / unify localization behavior

Before, we were doing double localization (Feeding a `LocalizedString` into a `.localizedStringWithFormat`).
 2017-12-17 16:10:57 -05:00
Ryan Nystrom
20e1b6f6df Design polish (#1275) 
* new tab icon design

* more spacing for action cells

* action cells larger, background colors

* fix assignee/reviewer spacing

* label colors, refine header spacing

* bump up label radius

* add close and lock options

* wire up close mutation

* wire up lock

* remove dead code
 2017-12-17 16:09:26 -05:00
Ryan Nystrom
0fc619e420 Tapping checkboxes updates the UI and edits on the server (#1272) 
* edit checkboxes working

* always can update when editing

* edit comment sent to client
 2017-12-17 09:19:19 -05:00
Bas Broek
7f04139794 Disable animations when reduce motion enabled (#1167) 2017-12-10 18:15:44 -05:00
Bas Broek
872da1f458 [Cleanup] Remove nil-default completion parameters (#1131) 
* Remove nil-default completion parameters

* Remove redundant character trimming
 2017-12-02 18:48:32 -05:00
Ryan Nystrom
3de0859b2e open fullscreen images when tapping web view (#1106) 2017-11-28 20:20:48 -05:00
Ryan Nystrom
086af29cbb allow double-tap like when reaction not visible (#1009) 2017-11-20 17:22:19 -05:00
Joe Rocca
76914651ad Adds double tap comment to 👍 (#809) 
* Added double tap on comment to react with thumbs up

* Changed func name for consistency

* added DoubleTappableCell to project file

* added no-op for PR review comments

* added pr review comment flag check instead of vc
 2017-11-19 16:47:34 -05:00
Ryan Nystrom
c0f7104554 Append a tail model for border on last PR comment in a thread (#869) 2017-11-06 09:02:23 -05:00
Ryan Nystrom
4733859946 Open PR comments in another VC (#828) 
* WIP PR comments

* thread comment count to PR review model

* PR review comments in another VC
 2017-11-04 21:46:21 -04:00
Rizwan Mohamed Ibrahim
6dd92b055f Changes on issue comment alert title and actions (#827) 
* [ADD] Comment alert title as "User's comment" and changes "Edit comment" to "Edit"

* [ADD] localized alert title

* Update IssueCommentSectionController.swift

* [ADD] Generic error when no login tapping more button

* [ADD] Generic error when no login tapping profile
 2017-11-04 11:00:28 -04:00
Hesham Salman
f213bac924 Thin SwiftLint ruleset (#704) 
* Thin SwiftLint ruleset

* Disabled trailing_whitespace rule
 2017-10-23 16:58:09 -04:00
Ryan Nystrom
357e7e1bde Finish wiring up edit comments (#594) 2017-10-18 12:14:17 -04:00
Ryan Nystrom
ca5ba59908 do safe area insetting on UICollectionView the "right" way, fixes #581 2017-10-16 09:41:56 -04:00
James Sherlock
edf76f42f3 Add ability to delete comments (#530) 
* Add alert action to delete comments, add viewerCanDelete variable

[skip ci]

* Add delete confirmation message

* Enable networking for deleting comments

* Updates as per @BasThomas feedback

* Update comment, oops
 2017-10-14 14:41:45 -04:00
Ryan Nystrom
4adfad92c8 flip didRemove guard 2017-10-13 18:38:58 -04:00
Ryan Nystrom
7d17e59609 prevent over reacting (lol), fixes #492 #510 2017-10-13 18:34:55 -04:00
Ryan Nystrom
cfd93c14a0 resuable cancel action, text view config, MD actions menu and control, init edit comments 2017-10-08 20:53:40 +01:00
Ryan Nystrom
1c38ff4d5c swift 4 migration 2017-10-07 14:46:10 +01:00
Ryan Nystrom
ce14d5118b animated reactions 2017-10-03 21:30:26 +02:00
Ivan Magda
f8d0cc7f12 Move duplicate share UIAlertActions to AlertAction struct #359 (#431) 
* Move duplicate share UIAlertActions to AlertActions struct #359

Create helper AlertActions struct for convenient UIAlertAction's instantiation.

* Create AlertActionBuilder #359

The AlertActionBuilder is used to create custom UIAlertAction's with constituent parts.

* Create UIAlertController+Action #359

UIAlertController+Action extension provide a convinient way for adding actions into the UIAlertController.

* Move additional UIAlertAction duplicates into AlertAction #359

* NewIssueTableViewController: Use correct titles for alert actions #359

Use "Go back" and "Discard" titles instead of "No" and "Yes".

* IssueCommentSectionController: Refactor alert actions #359

* SettingsViewController: Refactor onSignOut alert actions #359
 2017-09-29 16:21:17 -04:00
Ryan Nystrom
1b0e09c5f9 thread viewerCanUpdate for each comment 2017-09-27 22:33:42 -04:00
Ryan Nystrom
e9dad512e8 comment "send to" feature, fixes #393 2017-09-27 21:27:29 -04:00
Ryan Nystrom
b339731834 image size respects aspect ratio, fixes #417 2017-09-26 22:03:17 -04:00
Rizwan Mohamed Ibrahim
2a770c6a1b Fixes referenced issue view controller being pushed without nav bar (#423) 
* Fixes referenced issue view controller being pushed without nav bar

* Fixes referenced issue view controller being pushed without nav bar from Issues Review
 2017-09-25 10:34:01 -04:00
Ryan Nystrom
e8160beb00 haptic feedback on reaction 2017-09-17 21:06:08 -04:00
Ryan Nystrom
abb1411e46 local, optimistic emoji mutations 2017-09-17 20:32:25 -04:00
Ryan Nystrom
81a9a167ce shorthand issues are tappable to push new issue VC 2017-09-16 23:34:12 -04:00
Ryan Nystrom
6752d6fced html height working, fixes #72 2017-07-06 11:24:47 -04:00
Ryan Nystrom
c0aa7d012a remove head type from threaded comments, fixes #70 #69 2017-07-06 11:19:09 -04:00
Ryan Nystrom
a7975ceb58 huge refactor tomake comment SC code shareable 2017-07-05 21:13:04 -04:00
Ryan Nystrom
7400bb2a73 move comment model handling someplace that can be shared 2017-07-05 00:21:00 -04:00
Ryan Nystrom
aa7122fcb0 username tap handling, fixes #25 2017-07-05 00:06:17 -04:00