kylefang/GitHawk
1
0
Fork 0
mirror of https://github.com/zhigang1992/GitHawk.git synced 2026-05-28 06:36:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Changes on issue comment alert title and actions (#827)

Browse Source 
* [ADD] Comment alert title as "User's comment" and changes "Edit comment" to "Edit"

* [ADD] localized alert title

* Update IssueCommentSectionController.swift

* [ADD] Generic error when no login tapping more button

* [ADD] Generic error when no login tapping profile
This commit is contained in:
Rizwan Mohamed Ibrahim
2017-11-04 20:30:28 +05:30
committed by Ryan Nystrom
parent 1b9a8b2740
commit 6dd92b055f
1 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Classes/Issues/Comments/IssueCommentSectionController.swift
View File

@@ -102,7 +102,7 @@ EditCommentViewControllerDelegate {
func editAction() -> UIAlertAction? {
guard object?.viewerCanUpdate == true else { return nil }
return UIAlertAction(title: NSLocalizedString("Edit Comment", comment: ""), style: .default, handler: { [weak self] _ in
return UIAlertAction(title: NSLocalizedString("Edit", comment: ""), style: .default, handler: { [weak self] _ in
guard let markdown = self?.bodyEdits?.markdown ?? self?.object?.rawMarkdown,
let issueModel = self?.model,
let client = self?.client,
@@ -297,7 +297,17 @@ EditCommentViewControllerDelegate {
// MARK: IssueCommentDetailCellDelegate
func didTapMore(cell: IssueCommentDetailCell, sender: UIView) {
let alert = UIAlertController.configured(preferredStyle: .actionSheet)
guard let login = object?.details.login else {
ToastManager.showGenericError()
return
}
let alertTitle = NSLocalizedString("%@'s comment", comment: "Used in an action sheet title, eg. \"Basthomas's comment\".")
let alert = UIAlertController.configured(
title: .localizedStringWithFormat(alertTitle, login),
preferredStyle: .actionSheet
)
alert.popoverPresentationController?.sourceView = sender
alert.addActions([
shareAction(sender: sender),
@@ -309,7 +319,11 @@ EditCommentViewControllerDelegate {
}
func didTapProfile(cell: IssueCommentDetailCell) {
guard let login = object?.details.login else { return }
guard let login = object?.details.login else {
ToastManager.showGenericError()
return
}
viewController?.presentProfile(login: login)
}