kylefang/GitHawk
1
0
Fork 0
mirror of https://github.com/zhigang1992/GitHawk.git synced 2026-05-26 22:58:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

allow double-tap like when reaction not visible (#1009)

Browse Source
This commit is contained in:
Ryan Nystrom
2017-11-20 17:22:19 -05:00
committed by GitHub
parent e31e07821c
commit 086af29cbb
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
Classes/Issues/Comments/IssueCommentSectionController.swift
View File

@@ -139,7 +139,7 @@ DoubleTappableCellDelegate {
return true
}
private func react(cell: IssueCommentReactionCell, content: ReactionContent, isAdd: Bool) {
private func react(cell: IssueCommentReactionCell?, content: ReactionContent, isAdd: Bool) {
guard let object = self.object else { return }
let previousReaction = reactionMutation
@@ -150,7 +150,9 @@ DoubleTappableCellDelegate {
add: isAdd
)
reactionMutation = result.viewModel
cell.perform(operation: result.operation, content: content)
cell?.perform(operation: result.operation, content: content)
update(animated: true)
generator.impactOccurred()
client.react(subjectID: object.id, content: content, isAdd: isAdd) { [weak self] result in
@@ -318,16 +320,16 @@ DoubleTappableCellDelegate {
// MARK: DoubleTappableCellDelegate
func didDoubleTap(cell: DoubleTappableCell) {
guard let reactionCell = collectionContext?.cellForItem(at: numberOfItems() - 1, sectionController: self) as? IssueCommentReactionCell else {
return
}
let reaction = ReactionContent.thumbsUp
guard let reactions = reactionMutation ?? self.object?.reactions,
!reactions.viewerDidReact(reaction: reaction)
else { return }
react(cell: reactionCell, content: reaction, isAdd: true)
react(
cell: collectionContext?.cellForItem(at: numberOfItems() - 1, sectionController: self) as? IssueCommentReactionCell,
content: reaction,
isAdd: true
)
}
// MARK: IssueCommentDetailCellDelegate