kylefang/xverse-web-extension
1
0
Fork 0
mirror of https://github.com/zhigang1992/xverse-web-extension.git synced 2026-04-30 05:35:53 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
25bead5c968c42d5c84d028ec0e0f87a5dae9f18
xverse-web-extension/.github/PULL_REQUEST_TEMPLATE.md
Tim Man 25bead5c96 chore: update pr template (#859) 
* chore: update pr template

* chore: update pull request template after comments

* chore: update PULL_REQUEST_TEMPLATE.md

* chore: update PULL_REQUEST_TEMPLATE.md

---------

Co-authored-by: Den <36603049+dhriaznov@users.noreply.github.com>
2025-01-31 11:47:13 +01:00

2.3 KiB
Raw Blame History

Summary

Link to Linear issue (if not linked by bot):

  • PR Title was updated to match: <branch_type>: <descriptive, short message of what work was done> [<parent issue ID1>][<parent issue ID2>] See Branch types here

🖼 Screenshot / 📹 Video

Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.

Before After

🔄 Changes

  • What has been added, modified removed?
  • Where was the fix?
  • Include technical details and implications if necessary.
  • What xverse-core changes were included?

Impact:

  • Explain the broader impact of these changes.
  • Which areas of the application have been touched?
  • What should the tester be aware of when testing?
  • What can help the reviewer to be aware of when reading the code?
  • What are the security implications?

🔍 Testing Steps

  1. How to set up testing of the changes
  2. What steps to test
  3. What is expected

✅ Author checklist (can be draft if not all ready)

Please ensure the following are true before submitting for review:

  • The PR template has been filled.
  • E2E tests or unit tests have been added/updated.
  • The changes have been self-reviewed, and has been tidied up for an easy peer review.
    • No debugging code
    • No out of scope changes
    • Should the PR be split up for easier review?
  • The change has been manually tested and works as expected.
  • The PR has been labeled/flagged for QA if necessary.

✅ Reviewer checklist

  • The changes follow the intended scope.
  • Code is clean and readable. No anti-patterns, no code smells.
  • Code structure maintains separation of concerns.
  • Check that code does not belong in xverse-core, or also on mobile.
  • E2E tests or unit tests have been added/updated.
  • (If no QA) The PR has been manually tested and works as expected.