kylefang/wallet
1
0
Fork 0
mirror of https://github.com/zhigang1992/wallet.git synced 2026-04-29 05:05:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Ensure page events are tracked

Browse Source
This commit is contained in:
kyranjamie
2020-02-13 13:11:55 +01:00
parent d7fdbf8c35
commit e64396fc26
3 changed files with 24 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/app/src/components/onboarding/index.tsx
View File

@@ -43,7 +43,7 @@ const RenderScreen = ({ ...rest }) => {
/>
);
const UsernameScreen = () => <Username next={() => dispatch(doChangeScreen(ScreenName.CREATE))} {...rest} />;
const UsernameScreen = () => <Username next={() => dispatch(doChangeScreen(ScreenName.GENERATION))} {...rest} />;
switch (screen) {
// choose account
@@ -60,7 +60,7 @@ const RenderScreen = ({ ...rest }) => {
return <UsernameScreen />;
// create
case ScreenName.CREATE:
case ScreenName.GENERATION:
return <Create next={() => dispatch(doChangeScreen(ScreenName.SECRET_KEY))} {...rest} />;
// Key screens

12
packages/app/src/store/onboarding/actions.ts
View File

@@ -18,11 +18,15 @@ import { selectUsername, selectDecodedAuthRequest, selectAuthRequest, selectAppI
import { selectIdentities, selectCurrentWallet } from '@store/wallet/selectors';
import { finalizeAuthResponse } from '@common/utils';
import { gaiaUrl } from '@common/constants';
import { pageTrackingNameMap } from './types';
export const doChangeScreen = (screen: ScreenName): OnboardingActions => ({
type: CHANGE_PAGE,
screen,
});
export const doChangeScreen = (screen: ScreenName): OnboardingActions => {
window.analytics.page(pageTrackingNameMap[screen]);
return {
type: CHANGE_PAGE,
screen,
};
};
export const doSaveSecretKey = (secretKey: string): OnboardingActions => ({
type: SAVE_KEY,

15
packages/app/src/store/onboarding/types.ts
View File

@@ -9,7 +9,7 @@ export const SET_USERNAME = 'ONBOARDING/SET_USERNAME';
export enum ScreenName {
CHOOSE_ACCOUNT = 'screens/CHOOSE_ACCOUNT',
USERNAME = 'screens/USERNAME',
CREATE = 'screens/CREATE',
GENERATION = 'screens/GENERATION',
SECRET_KEY = 'screens/SECRET_KEY',
SAVE_KEY = 'screens/SAVE_KEY',
CONNECT_APP = 'screens/CONNECT_APP',
@@ -18,6 +18,19 @@ export enum ScreenName {
ADD_ACCOUNT = 'screens/ADD_ACCOUNT',
}
// Nice page names for Mark to see in Mixpanel
export const pageTrackingNameMap = {
[ScreenName.CHOOSE_ACCOUNT]: 'Choose Account',
[ScreenName.USERNAME]: 'Username',
[ScreenName.GENERATION]: 'Generation',
[ScreenName.SECRET_KEY]: 'Copy Secret Key',
[ScreenName.SAVE_KEY]: 'Save Secret Key',
[ScreenName.CONNECT_APP]: 'Connect App',
[ScreenName.SIGN_IN]: 'Sign In',
[ScreenName.RECOVERY_CODE]: 'Magic Recovery Code',
[ScreenName.ADD_ACCOUNT]: ' Select Username',
};
// TODO: clarify usage of password for local key encryption
export const DEFAULT_PASSWORD = 'password';