kylefang/stacks.js
1
0
Fork 0
mirror of https://github.com/alexgo-io/stacks.js.git synced 2026-01-12 22:52:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: verify deserialize spendending conditions

Browse Source
This commit is contained in:
AhsanJavaid
2021-09-14 18:51:06 +05:00
committed by Reed Rosenbluth
parent 1629ece26d
commit beea4e73bf
1 changed files with 30 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
packages/transactions/src/authorization.ts
View File

@@ -298,6 +298,11 @@ export function deserializeSingleSigSpendingCondition(
const keyEncoding = bufferReader.readUInt8Enum(PubKeyEncoding, n => {
throw new DeserializationError(`Could not parse ${n} as PubKeyEncoding`);
});
if (hashMode === AddressHashMode.SerializeP2WPKH && keyEncoding != PubKeyEncoding.Compressed) {
throw new DeserializationError(
'Failed to parse singlesig spending condition: incomaptible hash mode and key encoding'
);
}
const signature = deserializeMessageSignature(bufferReader);
return {
hashMode,
@@ -320,8 +325,33 @@ export function deserializeMultiSigSpendingCondition(
const fields = deserializeLPList(bufferReader, StacksMessageType.TransactionAuthField)
.values as TransactionAuthField[];
let haveUncompressed = false;
const numSigs = new Uint16Array(1);
numSigs[0] = 0;
for (const field of fields) {
switch (field.contents.type) {
case StacksMessageType.PublicKey:
if (!isCompressed(field.contents)) haveUncompressed = true;
break;
case StacksMessageType.MessageSignature:
if (field.pubKeyEncoding === PubKeyEncoding.Uncompressed) haveUncompressed = true;
numSigs[0] += 1;
if (numSigs[0] === 65536)
throw new VerificationError(
'Failed to parse multisig spending condition: too many signatures'
);
break;
}
}
const signaturesRequired = bufferReader.readUInt16BE();
if (numSigs[0] !== signaturesRequired)
throw new VerificationError(`Incorrect number of signatures`);
if (haveUncompressed && hashMode === AddressHashMode.SerializeP2SH)
throw new VerificationError('Uncompressed keys are not allowed in this hash mode');
return {
hashMode,
signer,