kylefang/stacks-puppet-node
1
0
Fork 0
mirror of https://github.com/alexgo-io/stacks-puppet-node.git synced 2026-05-30 15:55:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4468 from stacks-network/feat/pox-info-reward-cycle

Browse Source 
Fix: manually calculate current reward cycle ID in /v2/pox_info
This commit is contained in:
saralab
2024-03-05 09:39:35 +00:00
committed by GitHub
parent afe7e68ba4 d5af26e0ce
commit 11d74341d7
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
stackslib/src/net/api/getpoxinfo.rs
View File

@@ -226,12 +226,6 @@ impl RPCPoxInfoData {
.to_owned()
.expect_u128()? as u64;
let reward_cycle_id = res
.get("reward-cycle-id")
.unwrap_or_else(|_| panic!("FATAL: no 'reward-cycle-id'"))
.to_owned()
.expect_u128()? as u64;
let reward_cycle_length = res
.get("reward-cycle-length")
.unwrap_or_else(|_| panic!("FATAL: no 'reward-cycle-length'"))
@@ -292,7 +286,16 @@ impl RPCPoxInfoData {
return Err(NetError::DBError(DBError::Corruption));
}
// Manually calculate `reward_cycle_id` so that clients don't get an "off by one" view at
// reward cycle boundaries (because if the reward cycle is loaded from clarity, its
// evaluated in the last mined Stacks block, not the most recent burn block).
let reward_cycle_id = burnchain
.block_height_to_reward_cycle(burnchain_tip.block_height)
.ok_or_else(|| {
NetError::ChainstateError("Current burn block height is before stacks start".into())
})?;
let effective_height = burnchain_tip.block_height - first_burnchain_block_height;
let next_reward_cycle_in = reward_cycle_length - (effective_height % reward_cycle_length);
let next_rewards_start = burnchain_tip.block_height + next_reward_cycle_in;