kylefang/reactfire
1
0
Fork 0
mirror of https://github.com/zhigang1992/reactfire.git synced 2026-04-01 09:31:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Added error codes to all errors and updated test suite

Browse Source
This commit is contained in:
jacobawenger
2014-09-17 11:54:02 -07:00
parent 9a84bff4d7
commit 36b01f9cf5
2 changed files with 63 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/reactfire.js
View File

@@ -35,16 +35,20 @@ var ReactFireMixin = {
_bind: function(firebaseRef, bindVar, bindAsArray) {
this._validateBindVar(bindVar);
var error;
var errorMessage, errorCode;
if (Object.prototype.toString.call(firebaseRef) !== "[object Object]") {
error = "firebaseRef must be an instance of Firebase";
errorMessage = "firebaseRef must be an instance of Firebase";
errorCode = "INVALID_FIREBASE_REF";
}
else if (typeof bindAsArray !== "boolean") {
error = "bindAsArray must be a boolean. Got: " + bindAsArray;
errorMessage = "bindAsArray must be a boolean. Got: " + bindAsArray;
errorCode = "INVALID_BIND_AS_ARRAY";
}
if (typeof error !== "undefined") {
throw new Error("ReactFire: " + error);
if (typeof errorMessage !== "undefined") {
var error = new Error("ReactFire: " + errorMessage);
error.code = errorCode;
throw error;
}
this.firebaseRefs[bindVar] = firebaseRef.ref();
@@ -65,7 +69,9 @@ var ReactFireMixin = {
this._validateBindVar(bindVar);
if (typeof this.firebaseRefs[bindVar] === "undefined") {
throw new Error("unexpected value for bindVar. \"" + bindVar + "\" was either never bound or has already been unbound");
var error = new Error("ReactFire: unexpected value for bindVar. \"" + bindVar + "\" was either never bound or has already been unbound");
error.code = "UNBOUND_BIND_VARIABLE";
throw error;
}
this.firebaseRefs[bindVar].off("value", this.firebaseListeners[bindVar]);
@@ -79,25 +85,27 @@ var ReactFireMixin = {
/*************/
/* Validates the name of the variable which is being bound */
_validateBindVar: function(bindVar) {
var error;
var errorMessage;
if (typeof bindVar !== "string") {
error = "bindVar must be a string. Got: " + bindVar;
errorMessage = "bindVar must be a string. Got: " + bindVar;
}
else if (bindVar.length === 0) {
error = "bindVar must be a non-empty string. Got: \"\"";
errorMessage = "bindVar must be a non-empty string. Got: \"\"";
}
else if (bindVar.length > 768) {
// Firebase can only stored child paths up to 768 characters
error = "bindVar is too long to be stored in Firebase. Got: " + bindVar;
errorMessage = "bindVar is too long to be stored in Firebase. Got: " + bindVar;
}
else if (/[\[\].#$\/\u0000-\u001F\u007F]/.test(bindVar)) {
// Firebase does not allow node keys to contain the following characters
error = "bindVar cannot contain any of the following characters: . # $ ] [ /. Got: " + bindVar;
errorMessage = "bindVar cannot contain any of the following characters: . # $ ] [ /. Got: " + bindVar;
}
if (typeof error !== "undefined") {
throw new Error("ReactFire: " + error);
if (typeof errorMessage !== "undefined") {
var error = new Error("ReactFire: " + errorMessage);
error.code = "INVALID_BIND_VARIABLE";
throw error;
}
},

54
tests/specs/reactfire.spec.js
View File

@@ -9,8 +9,6 @@ describe("ReactFireMixin Tests:", function() {
describe("bindAsArray():", function() {
it("bindAsArray() throws errors given invalid Firebase refs", function() {
var expectedError = new Error("ReactFire: firebaseRef must be an instance of Firebase");
var TestComponent = React.createClass({
mixins: [ReactFireMixin],
@@ -18,7 +16,12 @@ describe("ReactFireMixin Tests:", function() {
var _this = this;
invalidFirebaseRefs.forEach(function(invalidFirebaseRef) {
expect(function() { _this.bindAsArray(invalidFirebaseRef, "items"); }).toThrow(expectedError);
try {
_this.bindAsArray(invalidFirebaseRef, "items");
expect("Function should throw error given parameter: " + invalidFirebaseRef).toBeFalsy();
} catch (error) {
expect(error.code).toEqual("INVALID_FIREBASE_REF");
}
});
},
@@ -38,7 +41,12 @@ describe("ReactFireMixin Tests:", function() {
var _this = this;
invalidBindVars.forEach(function(invalidBindVar) {
expect(function() { _this.bindAsArray(firebaseRef, invalidBindVar); }).toThrow();
try {
_this.bindAsArray(firebaseRef, invalidBindVar);
expect("Function should throw error given parameter: " + invalidBindVar).toBeFalsy();
} catch (error) {
expect(error.code).toEqual("INVALID_BIND_VARIABLE");
}
});
},
@@ -141,8 +149,6 @@ describe("ReactFireMixin Tests:", function() {
describe("bindAsObject():", function() {
it("bindAsObject() throws errors given invalid Firebase refs", function() {
var expectedError = new Error("ReactFire: firebaseRef must be an instance of Firebase");
var TestComponent = React.createClass({
mixins: [ReactFireMixin],
@@ -150,7 +156,12 @@ describe("ReactFireMixin Tests:", function() {
var _this = this;
invalidFirebaseRefs.forEach(function(invalidFirebaseRef) {
expect(function() { _this.bindAsObject(invalidFirebaseRef, "items"); }).toThrow(expectedError);
try {
_this.bindAsObject(invalidFirebaseRef, "items");
expect("Function should throw error given parameter: " + invalidFirebaseRef).toBeFalsy();
} catch (error) {
expect(error.code).toEqual("INVALID_FIREBASE_REF");
}
});
},
@@ -170,7 +181,12 @@ describe("ReactFireMixin Tests:", function() {
var _this = this;
invalidBindVars.forEach(function(invalidBindVar) {
expect(function() { _this.bindAsObject(firebaseRef, invalidBindVar); }).toThrow();
try {
_this.bindAsObject(firebaseRef, invalidBindVar);
expect("Function should throw error given parameter: " + invalidBindVar).toBeFalsy();
} catch (error) {
expect(error.code).toEqual("INVALID_BIND_VARIABLE");
}
});
},
@@ -280,7 +296,12 @@ describe("ReactFireMixin Tests:", function() {
var _this = this;
invalidBindVars.forEach(function(invalidBindVar) {
expect(function() { _this.unbind(invalidBindVar); }).toThrow();
try {
_this.unbind(invalidBindVar);
expect("Function should throw error given parameter: " + invalidBindVar).toBeFalsy();
} catch (error) {
expect(error.code).toEqual("INVALID_BIND_VARIABLE");
}
});
},
@@ -300,7 +321,12 @@ describe("ReactFireMixin Tests:", function() {
var _this = this;
validBindVars.forEach(function(validBindVar) {
expect(function() { _this.unbind(validBindVar); }).toThrow();
try {
_this.unbind(validBindVar);
expect("Function should throw error given parameter: " + validBindVar).toBeFalsy();
} catch (error) {
expect(error.code).toEqual("UNBOUND_BIND_VARIABLE");
}
});
},
@@ -420,8 +446,12 @@ describe("ReactFireMixin Tests:", function() {
var _this = this;
nonBooleanParams.forEach(function(nonBooleanParam) {
var expectedError = new Error("ReactFire: bindAsArray must be a boolean. Got: " + nonBooleanParam);
expect(function() { _this._bind(firebaseRef, "items", nonBooleanParam); }).toThrow(expectedError);
try {
_this._bind(firebaseRef, "items", nonBooleanParam);
expect("Function should throw error given parameter: " + nonBooleanParam).toBeFalsy();
} catch (error) {
expect(error.code).toEqual("INVALID_BIND_AS_ARRAY");
}
});
},