Satyajit Sahoo
c333f4086e
fix: fix devtools not sending new events if an error occured
2021-07-16 10:29:59 +02:00
DrRefactor
16f0e11822
fix: prevent navigation state updates after state cleanup ( #9688 )
...
Problem:
When using nested navigators, unmounts cause race cleanup races.
Imagine following hierarchy (from tree root downwards, parent to children):
TabNavigator (1) [renders useNavigationBuilder]
SceneView (from TabNavigator)
StackNavigators (N) [each renders useNavigationBuilder]
SceneView (from StackNavigator)
Now lets test following flow:
1. Mount above navigators with given navigation params (e.g. navigation for unauthenticated users)
2. Unmount all navigators (e.g. during login process)
3. Mount above navigation with different navigation params than in 1) (e.g. navigation for authenticated users)
What you'll observe, there will be old navigation params preserved in 3) coming from 1).
Source of problem:
BaseNavigationContainer holds global navigation state, exposes API to modify it via NavigationStateContext. When useNavigationBuilder unmounts, it attempts to clear navigation state. (see cleanup effect in useNavigationBuilder.tsx).
(I) First clear occurs in TabNavigator's effect, which successfully clears BaseNavigationContainer's state (sets it to undefined).
(II) Second clear comes from StackNavigator unmount. It's useNavigationBuilder cleanup effect also calls NavigationStateContext.setState(undefined).
But this time - we meet SceneView as closest NavigationStateContext.Provider. SceneView attempts to merge state change with current navigation state, which is reasonable. But current navigation state should be already undefined... It is, but:
```
[useNavigationBuilder.tsx]
const getState = React.useCallback((): State => {
const currentState = getCurrentState();
return isStateInitialized(currentState)
? (currentState as State)
: (initializedStateRef.current as State);
}, [getCurrentState, isStateInitialized]);
```
"undefined" state is treated is non-initialized state, and freshly computed state (initializedStateRef.current) is returned instead.
SceneView does merge this old state with `undefined` value, and passes to BaseNavigationContainer. Now we have some legacy global state, despite all navigators being unmounted.
After mounting navigators again (3), we can observe old params being restored. These params might come e.g. from old `initialParams` prop (from 1)).
Solution:
Do not propagate `setState` upwards in `useNavigationBuilder` after state cleanup. This way we'll omit such races.
2021-07-16 10:29:26 +02:00
Michael Ru
ee12690a82
fix: update isClosing in stack card ( #9738 )
...
I noticed that accessing `closing` through `cardStyleInterpolator` would always return an Animated node with value 0. It looks like it isn't being updated anywhere, so I added it to the `animate` method.
I am using this functionality to allow screens to have different in and out transitions.
On a side note, I feel like this would be more useful as a boolean, instead of an Animated value.
Co-authored-by: Michael Ru <michaelru@abridge.com >
2021-07-16 10:25:51 +02:00
Zhigang Fang
4135d09c6f
fix: sort wildcard and :params ( #9672 )
2021-07-01 13:28:46 +02:00
Satyajit Sahoo
a70adfbca1
chore: publish
...
- @react-navigation/bottom-tabs@6.0.0-next.20
- @react-navigation/core@6.0.0-next.15
- @react-navigation/devtools@6.0.0-next.16
- @react-navigation/drawer@6.0.0-next.19
- @react-navigation/elements@1.0.0-next.19
- flipper-plugin-react-navigation@1.3.0
- @react-navigation/material-bottom-tabs@6.0.0-next.16
- @react-navigation/material-top-tabs@6.0.0-next.16
- @react-navigation/native-stack@6.0.0-next.9
- @react-navigation/native@6.0.0-next.15
- @react-navigation/routers@6.0.0-next.6
- @react-navigation/stack@6.0.0-next.27
2021-07-01 03:08:40 +02:00
Satyajit Sahoo
b1134c8a34
fix: fix typechecking in linking config
2021-07-01 03:06:37 +02:00
Satyajit Sahoo
d2e1571b53
chore: update the issue templates
2021-06-30 09:50:49 +02:00
Satyajit Sahoo
b1d935ca53
chore: add an action to check labels
2021-06-27 07:49:45 +02:00
Satyajit Sahoo
3a5d096547
chore: add new issue forms
2021-06-27 07:20:36 +02:00
Satyajit Sahoo
20b8ebd405
fix: disable duplicate linking check for independent containers
2021-06-27 01:32:15 +02:00
Cedric van Putten
4c16083d51
chore: upgrade to expo-github-actions v6
2021-06-23 15:40:22 +02:00
Satyajit Sahoo
e7631ea239
chore: comment on closed issues regarding watching
2021-06-15 03:32:04 +02:00
Max Schmitt
2ee435be3a
chore: add nvmrc for using LTS Node.js version ( #9668 )
...
This should fix the Netlify builds too.
See here for reference: https://github.com/nvm-sh/nvm#nvmrc
The integration tests are failing but they are getting fixed in #9667 .
2021-06-13 17:39:55 +02:00
Max Schmitt
016e7920df
test: upgrade to the new Playwright test-runner ( #9667 )
...
Hey!
I made the following changes:
- Replaced Jest by the new Playwright test-runner
- Disabled the Jest linting rules for the Playwright e2e tests
- Rewrote the tests to the new test-runner
- Adjusted `Link.test.ts` which should be less flaky
- The tests run now across all three browsers: Chromium, Firefox, and WebKit
See here for reference about the new test-runner: https://playwright.dev/docs/test-intro
I extracted a fix for Netlify in #9668 .
Let me know if you have any questions.
2021-06-13 17:38:46 +02:00
Satyajit Sahoo
26ba019155
chore: publish
...
- @react-navigation/bottom-tabs@6.0.0-next.19
- @react-navigation/core@6.0.0-next.14
- @react-navigation/devtools@6.0.0-next.15
- @react-navigation/drawer@6.0.0-next.18
- @react-navigation/elements@1.0.0-next.18
- flipper-plugin-react-navigation@1.2.0
- @react-navigation/material-bottom-tabs@6.0.0-next.15
- @react-navigation/material-top-tabs@6.0.0-next.15
- @react-navigation/native-stack@6.0.0-next.8
- @react-navigation/native@6.0.0-next.14
- @react-navigation/routers@6.0.0-next.5
- @react-navigation/stack@6.0.0-next.26
2021-06-11 01:15:43 +02:00
Satyajit Sahoo
97772affa3
feat: show stack trace in the flipper plugin
2021-06-11 01:09:02 +02:00
Satyajit Sahoo
67f6950c14
chore: upgrade dependencies
2021-06-05 07:33:26 +02:00
Satyajit Sahoo
fe6d20c10e
chore: publish
...
- @react-navigation/bottom-tabs@6.0.0-next.18
- @react-navigation/drawer@6.0.0-next.17
- @react-navigation/elements@1.0.0-next.17
- @react-navigation/material-bottom-tabs@6.0.0-next.14
- @react-navigation/native-stack@6.0.0-next.7
- @react-navigation/stack@6.0.0-next.25
2021-06-01 13:30:34 +02:00
Satyajit Sahoo
7d74bd73a7
fix: tweak android q animation
2021-06-01 04:21:51 +02:00
Satyajit Sahoo
b46c433f1e
fix: tweak opacity animation for PlatformPressable
2021-06-01 03:17:16 +02:00
Satyajit Sahoo
7e71ee6c47
chore: revert yarn.lock
2021-06-01 03:14:25 +02:00
Satyajit Sahoo
1287a784e6
chore: fix mapping in server babel config
2021-05-31 20:42:07 +02:00
Satyajit Sahoo
56f7df5384
chore: fix running the example app on web
2021-05-31 20:12:05 +02:00
Satyajit Sahoo
5996bbbce2
chore: bump react-native-paper
2021-05-31 19:31:08 +02:00
Satyajit Sahoo
c3ba72df65
chore: publish
...
- @react-navigation/bottom-tabs@6.0.0-next.17
- @react-navigation/core@6.0.0-next.13
- @react-navigation/devtools@6.0.0-next.14
- @react-navigation/drawer@6.0.0-next.16
- @react-navigation/elements@1.0.0-next.16
- flipper-plugin-react-navigation@1.1.4
- @react-navigation/material-bottom-tabs@6.0.0-next.13
- @react-navigation/material-top-tabs@6.0.0-next.14
- @react-navigation/native-stack@6.0.0-next.6
- @react-navigation/native@6.0.0-next.13
- @react-navigation/stack@6.0.0-next.24
2021-05-29 20:35:14 +02:00
Satyajit Sahoo
be40244214
chore: remove unused dep from flipper plugin
2021-05-29 20:32:41 +02:00
Satyajit Sahoo
7388e6d9bc
chore: add a LICENSE to flipper plugin
2021-05-29 20:27:59 +02:00
Satyajit Sahoo
00e70da0d4
chore: add repository entry to flipper plugin
2021-05-29 20:22:52 +02:00
Satyajit Sahoo
70f4fe2ffa
fix: remove card shadow from default animation
...
closes #9569
2021-05-29 20:16:41 +02:00
Satyajit Sahoo
e639748b23
refactor: rename headerSearchBar to headerSearchBarOptions
2021-05-29 20:04:30 +02:00
Satyajit Sahoo
324ea7181d
fix: validate property names in linking config
2021-05-29 20:03:10 +02:00
Satyajit Sahoo
9d3731c2df
chore: add a README to Flipper plugin
2021-05-29 19:28:39 +02:00
Satyajit Sahoo
baf8ff77d5
chore: publish
...
- @react-navigation/bottom-tabs@6.0.0-next.16
- @react-navigation/core@6.0.0-next.12
- @react-navigation/devtools@6.0.0-next.13
- @react-navigation/drawer@6.0.0-next.15
- @react-navigation/elements@1.0.0-next.15
- flipper-plugin-react-navigation@1.1.3
- @react-navigation/material-bottom-tabs@6.0.0-next.12
- @react-navigation/material-top-tabs@6.0.0-next.13
- @react-navigation/native-stack@6.0.0-next.5
- @react-navigation/native@6.0.0-next.12
- @react-navigation/stack@6.0.0-next.23
2021-05-29 16:04:32 +02:00
Satyajit Sahoo
b4d7b0ee86
fix: try to fix #9631
2021-05-29 16:02:40 +02:00
Satyajit Sahoo
a184ce24b3
chore: publish
...
- @react-navigation/bottom-tabs@6.0.0-next.15
- @react-navigation/core@6.0.0-next.11
- @react-navigation/devtools@6.0.0-next.12
- @react-navigation/drawer@6.0.0-next.14
- @react-navigation/elements@1.0.0-next.14
- flipper-plugin-react-navigation@1.1.2
- @react-navigation/material-bottom-tabs@6.0.0-next.11
- @react-navigation/material-top-tabs@6.0.0-next.12
- @react-navigation/native-stack@6.0.0-next.4
- @react-navigation/native@6.0.0-next.11
- @react-navigation/routers@6.0.0-next.4
- @react-navigation/stack@6.0.0-next.22
2021-05-27 18:50:18 +02:00
Satyajit Sahoo
80cdc88588
fix: use safe area context in material bottom tabs
2021-05-27 18:48:44 +02:00
Satyajit Sahoo
b91c9b05ff
chore: sort imports automatically
2021-05-26 21:29:11 +02:00
Satyajit Sahoo
29cdd886a0
chore: publish
...
- @react-navigation/bottom-tabs@6.0.0-next.14
- @react-navigation/core@6.0.0-next.10
- @react-navigation/devtools@6.0.0-next.11
- @react-navigation/drawer@6.0.0-next.13
- @react-navigation/elements@1.0.0-next.13
- flipper-plugin-react-navigation@1.1.1
- @react-navigation/material-bottom-tabs@6.0.0-next.10
- @react-navigation/material-top-tabs@6.0.0-next.11
- @react-navigation/native-stack@6.0.0-next.3
- @react-navigation/native@6.0.0-next.10
- @react-navigation/stack@6.0.0-next.21
2021-05-26 21:12:06 +02:00
Satyajit Sahoo
1d40279db1
feat: expose container ref in useNavigation
2021-05-26 21:06:16 +02:00
Satyajit Sahoo
cde44a5785
feat: add screenListeners prop on navigators similar to screenOptions
2021-05-26 00:41:09 +02:00
Satyajit Sahoo
aa77f0618b
chore: publish
...
- @react-navigation/bottom-tabs@6.0.0-next.13
- @react-navigation/devtools@6.0.0-next.10
- @react-navigation/drawer@6.0.0-next.12
- @react-navigation/elements@1.0.0-next.12
- @react-navigation/native-stack@6.0.0-next.2
- @react-navigation/stack@6.0.0-next.20
2021-05-25 11:41:39 +02:00
Satyajit Sahoo
a5520d7ef1
fix: make react-native-flipper optional in devtools
2021-05-25 11:41:21 +02:00
Satyajit Sahoo
0c1a061a04
chore: minor tweaks
2021-05-24 21:24:57 +02:00
Satyajit Sahoo
d5f5521d5d
chore: publish
...
- @react-navigation/stack@6.0.0-next.19
2021-05-24 15:10:52 +02:00
Satyajit Sahoo
c90bff08d5
fix: make transparent modal work with modal presentation
2021-05-24 15:10:28 +02:00
Satyajit Sahoo
b5903373ad
chore: publish
...
- @react-navigation/bottom-tabs@6.0.0-next.12
- @react-navigation/core@6.0.0-next.9
- @react-navigation/devtools@6.0.0-next.9
- @react-navigation/drawer@6.0.0-next.11
- @react-navigation/elements@1.0.0-next.11
- flipper-plugin-react-navigation@1.1.0
- @react-navigation/material-bottom-tabs@6.0.0-next.9
- @react-navigation/material-top-tabs@6.0.0-next.10
- @react-navigation/native-stack@6.0.0-next.1
- @react-navigation/native@6.0.0-next.9
- @react-navigation/routers@6.0.0-next.3
- @react-navigation/stack@6.0.0-next.18
2021-05-23 08:04:32 +02:00
Satyajit Sahoo
1397bee710
chore: fix albums screen padding in native stack
2021-05-22 00:13:11 +02:00
Satyajit Sahoo
15ede8112e
refactor: align header options for native stack and regular stack
2021-05-22 00:04:29 +02:00
Satyajit Sahoo
6dc5364089
refactor: drop openByDefault in favor of defaultStatus prop
2021-05-21 14:39:15 +02:00
Satyajit Sahoo
3d147401e8
feat: add 'transparentModal' presentation to JS stack
2021-05-21 14:20:27 +02:00
