refactor: remove undefined assignment in switch router (#8770)

`undefined` should be left to the javascript compiler.

Originally, I opened this PR because I thought there was an inconsistency between the stack and switch routers, in the way they handle params. Turns out it's all fine, but I found this case where `undefined` is assigned to a variable and I thought I could submit a small refactor for it.
This commit is contained in:
oltrep
2020-09-21 06:20:36 -07:00
committed by GitHub
parent 62da341b67
commit c0763fca16

View File

@@ -19,7 +19,7 @@ export default (routeConfigs, config = {}) => {
const getCustomActionCreators =
config.getCustomActionCreators || defaultActionCreators;
const initialRouteParams = config.initialRouteParams;
const { initialRouteParams } = config;
const initialRouteName = config.initialRouteName || order[0];
const backBehavior = config.backBehavior || 'none';
const resetOnBlur = config.hasOwnProperty('resetOnBlur')
@@ -59,7 +59,7 @@ export default (routeConfigs, config = {}) => {
function resetChildRoute(routeName) {
let initialParams =
routeName === initialRouteName ? initialRouteParams : undefined;
routeName === initialRouteName ? initialRouteParams : null;
// note(brentvatne): merging initialRouteParams *on top* of default params
// on the route seems incorrect but it's consistent with existing behavior
// in stackrouter
@@ -71,13 +71,13 @@ export default (routeConfigs, config = {}) => {
...childRouter.getStateForAction(childAction),
key: routeName,
routeName,
params,
...(params ? { params } : {}),
};
}
return {
key: routeName,
routeName,
params,
...(params ? { params } : {}),
};
}