kylefang/react-navigation
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-navigation.git synced 2026-05-15 07:57:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: drop custom history logic for isFirstRouteInParent (#52)

Browse Source 
As the naming suggests, this checks if route is the first one in parent. So probably doesn't make sense to check history.
This commit is contained in:
Satyajit Sahoo
2019-04-10 19:14:05 +02:00
parent 3a1f1e0df4
commit 9434cfa418
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/core/src/getChildNavigation.js
View File

@@ -60,13 +60,8 @@ function getChildNavigation(navigation, childKey, getCurrentParentNavigation) {
const parentNavigation = getCurrentParentNavigation();
if (parentNavigation) {
isFirstRouteInParent = parentNavigation.routeKeyHistory
? // For navigators such as switch/tab navigators, history is separate from routes
parentNavigation.routeKeyHistory.length
? parentNavigation.routeKeyHistory.indexOf(childKey) === 0
: true
: // For stack navigator, list of routes is the same as the history
parentNavigation.state.routes.indexOf(childRoute) === 0;
isFirstRouteInParent =
parentNavigation.state.routes.indexOf(childRoute) === 0;
}
if (