kylefang/react-navigation
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-navigation.git synced 2026-04-26 05:25:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix Transitioner race condition (#3434)

Browse Source 
This code was added during the events implementation, but I think we should be able to manage this circumstance from the parent context. In any case, any events bugs that result from this change will be far less insidious than the cardstack transitioner issue we experience now
This commit is contained in:
Eric Vicenti
2018-02-05 10:52:08 -08:00
committed by Brent Vatne
parent 63a6565afa
commit 03fbd98ce4
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/views/Transitioner.js
View File

@@ -120,15 +120,6 @@ class Transitioner extends React.Component {
]
: [];
// When there are no animations happening, avoid calling onTransitionStart/End.
// This is important because the stack navigator fires the completion prop when
// the transition is ended.
if (!animations.length) {
this._isTransitionRunning = false;
this.setState(nextState);
return;
}
// update scenes and play the transition
this._isTransitionRunning = true;
this.setState(nextState, async () => {