react-native

mirror of https://github.com/zhigang1992/react-native.git synced 2026-02-09 09:12:06 +08:00

Go to file

James Ide 62766e6077 [Text] Account for font leading so descenders are not clipped

Summary:
Prior to this diff, descenders (the hanging tail on letters like g and j) were clipped on the last line because the text measurer did not account for the font leading. With `NSStringDrawingUsesFontLeading` it honors the fonts line spacing.

To test: open the Text demo of the UIExplorer and see that the bottom of the letter g is no longer clipped off.

## Before

![Screenshot Before](https://cloud.githubusercontent.com/assets/379606/6364746/1c5527a0-bc60-11e4-8aeb-2147a6eb6596.png)

## After

![Screenshot After](https://cloud.githubusercontent.com/assets/379606/6364747/1e9abe58-bc60-11e4-8c34-9f20ad8572ff.png)
Closes https://github.com/facebook/react-native/pull/96
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.

2015-03-23 11:40:24 -08:00

Examples

more UIExplorer flow

2015-03-23 11:21:08 -08:00

IntegrationTests

[ReactNative] Add AsyncStorageTest

2015-03-18 13:15:40 -08:00

jestSupport

[react-packager] Better transform errors

2015-02-28 17:13:23 -08:00

Libraries

[Text] Account for font leading so descenders are not clipped