kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-15 07:28:31 +08:00
Code Issues Packages Projects Releases Wiki Activity
9,592 Commits 46 Branches 129 Tags
67f6b32409f78cb1d5bb6a4dc5cf35a27692b08d
Commit Graph

9 Commits

Author SHA1 Message Date
David Hart
67f6b32409 Rename YGUnitPixel to YGPoint... 
Summary:
...to reflect the modern world we live in with dynamic DPI platforms :)
Closes https://github.com/facebook/yoga/pull/375

Reviewed By: dshahidehpour

Differential Revision: D4528518

Pulled By: emilsjolander

fbshipit-source-id: e422bd4ae148e02c598a7b484a6adfa8c0e1e0c9
 2017-02-14 14:31:31 -08:00
Emil Sjolander
3f49e743be Add percentage support to react native 
Summary:
Adds support for percentage value in react native.

syntax: property: 100 | property | '100%'

supported properties:
padding
margin
width
height
minWidth
minHeight
maxWidth
maxHeight
flexBasis

```
class Playground extends React.Component {
  render() {
    return (
      <View style={{backgroundColor: 'white', padding: 10, paddingTop: 30, height: '100%'}}>
        <Text>
          If you want to quickly test out something,
          open the Playground.js file and start coding.
        </Text>
        <View style={{backgroundColor: 'red', height: 50, width: 50}}/>
        <View style={{backgroundColor: 'blue', height: '50%', width: '50%'}}/>
      </View>
    );
  }
}
```

Reviewed By: astreet

Differential Revision: D4376549

fbshipit-source-id: c41d68a7555396f95d063a7527ee081773ac56dc
 2017-01-11 03:58:37 -08:00
Emil Sjolander
9724eaeb42 Fix checks for already set padding 
Reviewed By: ahmedre

Differential Revision: D4393371

fbshipit-source-id: 96672d0ee38b16b6f225c8a6fe0442c9b9eb9ec8
 2017-01-10 02:28:28 -08:00
Ahmed El-Helw
d73746774b Fix SurfaceView not redrawing when it should 
Summary:
Like its non-Nodes counterpart, FlatARTSurfaceViewShadowNode
should redraw when extra updates are collected.

Reviewed By: sriramramani

Differential Revision: D4355702

fbshipit-source-id: 6e7b90360958481f5bef9b806eca9fa888cb6a32
 2016-12-20 18:28:38 -08:00
Andy Street
bb8d540cf7 Use markUpdated instead of dirty setPadding in nodes 
Summary: setPadding already calls dirty, and we should only be calling dirty on nodes that have measure functions.

Reviewed By: emilsjolander

Differential Revision: D4205148
 2016-12-19 13:40:35 -08:00
Emil Sjolander
3fff811c57 call super instead of self 
Summary: Call super.setPadding. Calling the overriden version will cause stack overflow.

Differential Revision: D4096141
 2016-12-19 13:40:35 -08:00
Emil Sjolander
c10bbe5599 Dont create a spacing object for returning margin, padding, border, and position 
Summary: The current implementation was made out of simplicity and to keep the same API as before. Now that the java version of csslayout is deprecated it is time to change the API to make the calls more efficient for the JNI version. This diff with reduce allocations as well as reduce the number of JNI calls done.

Differential Revision: D4050773
 2016-12-19 13:40:35 -08:00
Dmitry Petukhov
e1b0d32bde Two ReactART TODOs implemented on Android 
Summary:
Implemented 2 TODOs from ReactART for Android:
- TODO(7255985): Use TextureView and pass Surface from the view to draw on it asynchronously instead of passing the bitmap (which is inefficient especially in terms of memory usage)
- TODO(6352067): Support dashes in ARTShape

We use ReactNativeART in our Android project.
1. Our app crashes sometimes on large screen smartphones with OutOfMemoryError. Crashes happen in ARTSurfaceShadowNode where TODO(7255985) was suggested in a comment in order to use memory more efficiently.
2. We needed dashes for drawing on ARTSurface.

**Test plan (required)**

I attach a screenshot of our app which shows dashed-lines and two ARTSurfaces on top of each other rendering exactly the same as in the pervious implementation of ARTSurface.
![screenshot_2016-08-19-16-45-43](https://cloud.githubusercontent.com/assets/18415611/17811741/cafc35c4-662c-11e6-8a63-7c35ef1c5ba9.png)
Closes https://github.com/facebook/react-native/pull/9486

Differential Revision: D4021303

Pulled By: foghina
 2016-12-19 13:40:34 -08:00
Ahmed El-Helw
7cc4e0364a Fix ARTSurfaceView with Nodes 
Summary: ARTSurfaceView wasn't working for Nodes. This patch fixes it.

Differential Revision: D3653522
 2016-12-19 13:40:30 -08:00