kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-02-10 09:12:46 +08:00
Code Issues Packages Projects Releases Wiki Activity

Cancel previous calls to -[RCTImageView reloadImage] to prevent extra work

Browse Source 
Reviewed By: @tadeuzagallo

Differential Revision: D2470902
This commit is contained in:
Justin Spahr-Summers
2015-09-23 07:30:36 -07:00
committed by facebook-github-bot-8
parent 75d0b904b9
commit de85bcab0b
1 changed files with 32 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
Libraries/Image/RCTImageView.m
View File

@@ -32,6 +32,12 @@
{
RCTBridge *_bridge;
CGSize _targetSize;
/**
* A block that can be invoked to cancel the most recent call to -reloadImage,
* if any.
*/
RCTImageLoaderCancellationBlock _reloadImageCancellationBlock;
}
- (instancetype)initWithBridge:(RCTBridge *)bridge
@@ -120,8 +126,26 @@ RCT_NOT_IMPLEMENTED(- (instancetype)init)
}
}
- (void)cancelImageLoad
{
RCTImageLoaderCancellationBlock previousCancellationBlock = _reloadImageCancellationBlock;
if (previousCancellationBlock) {
previousCancellationBlock();
_reloadImageCancellationBlock = nil;
}
}
- (void)clearImage
{
[self cancelImageLoad];
[self.layer removeAnimationForKey:@"contents"];
self.image = nil;
}
- (void)reloadImage
{
[self cancelImageLoad];
if (_src && !CGSizeEqualToSize(self.frame.size, CGSizeZero)) {
if (_onLoadStart) {
@@ -138,13 +162,12 @@ RCT_NOT_IMPLEMENTED(- (instancetype)init)
};
}
[_bridge.imageLoader loadImageWithTag:_src
size:self.bounds.size
scale:RCTScreenScale()
resizeMode:self.contentMode
progressBlock:progressHandler
completionBlock:^(NSError *error, UIImage *image) {
_reloadImageCancellationBlock = [_bridge.imageLoader loadImageWithTag:_src
size:self.bounds.size
scale:RCTScreenScale()
resizeMode:self.contentMode
progressBlock:progressHandler
completionBlock:^(NSError *error, UIImage *image) {
if (image.reactKeyframeAnimation) {
[self.layer addAnimation:image.reactKeyframeAnimation forKey:@"contents"];
} else {
@@ -165,8 +188,7 @@ RCT_NOT_IMPLEMENTED(- (instancetype)init)
}
}];
} else {
[self.layer removeAnimationForKey:@"contents"];
self.image = nil;
[self clearImage];
}
}
@@ -195,8 +217,7 @@ RCT_NOT_IMPLEMENTED(- (instancetype)init)
[super didMoveToWindow];
if (!self.window) {
[self.layer removeAnimationForKey:@"contents"];
self.image = nil;
[self clearImage];
} else if (self.src) {
[self reloadImage];
}