kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-01-12 22:50:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Remove null coalescing operators in ShadowNode (#23438)

Browse Source 
Summary:
This pull request removes the use of the GCC extension null coalescing operators (`?:`) and replaces them with ternary operators. This improves the portability of `ShadowNode.cpp` (and enables MSVC to build it)

[General] [Fixed] - Fabric: Removed null coalescing operators in `ShadowNode`
Pull Request resolved: https://github.com/facebook/react-native/pull/23438

Differential Revision: D14304958

Pulled By: shergin

fbshipit-source-id: 7d8e6778a72dabf09b1d99bc091a7578598b79c3
This commit is contained in:
empyrical
2019-03-04 14:38:36 -08:00
committed by Facebook Github Bot
parent b30b10326e
commit ddd5b25768
1 changed files with 17 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
ReactCommon/fabric/core/shadownode/ShadowNode.cpp
View File

@@ -32,7 +32,9 @@ ShadowNode::ShadowNode(
rootTag_(fragment.rootTag),
props_(fragment.props),
eventEmitter_(fragment.eventEmitter),
children_(fragment.children ?: emptySharedShadowNodeSharedList()),
children_(
fragment.children ? fragment.children
: emptySharedShadowNodeSharedList()),
state_(fragment.state),
componentDescriptor_(componentDescriptor),
childrenAreShared_(true),
@@ -44,13 +46,20 @@ ShadowNode::ShadowNode(
ShadowNode::ShadowNode(
const ShadowNode &sourceShadowNode,
const ShadowNodeFragment &fragment)
: tag_(fragment.tag ?: sourceShadowNode.tag_),
rootTag_(fragment.rootTag ?: sourceShadowNode.rootTag_),
props_(fragment.props ?: sourceShadowNode.props_),
eventEmitter_(fragment.eventEmitter ?: sourceShadowNode.eventEmitter_),
children_(fragment.children ?: sourceShadowNode.children_),
localData_(fragment.localData ?: sourceShadowNode.localData_),
state_(fragment.state ?: sourceShadowNode.getCommitedState()),
: tag_(fragment.tag ? fragment.tag : sourceShadowNode.tag_),
rootTag_(fragment.rootTag ? fragment.rootTag : sourceShadowNode.rootTag_),
props_(fragment.props ? fragment.props : sourceShadowNode.props_),
eventEmitter_(
fragment.eventEmitter ? fragment.eventEmitter
: sourceShadowNode.eventEmitter_),
children_(
fragment.children ? fragment.children : sourceShadowNode.children_),
localData_(
fragment.localData ? fragment.localData
: sourceShadowNode.localData_),
state_(
fragment.state ? fragment.state
: sourceShadowNode.getCommitedState()),
componentDescriptor_(sourceShadowNode.componentDescriptor_),
childrenAreShared_(true),
revision_(sourceShadowNode.revision_ + 1) {