kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-01-12 22:50:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

JSBigString to map via MAP_PRIVATE not MAP_SHARED

Browse Source 
Summary:
JSBigString was inadvertently changed to a shared mapping. This means
that any changes to the string will be written back to the file. Ensure
we have a private (COW) mapping.

Reviewed By: kodafb

Differential Revision: D14532757

fbshipit-source-id: 6afb9635493496c90904f1432847c2f0da882c58
This commit is contained in:
Peter Ammon
2019-03-21 14:18:28 -07:00
committed by Facebook Github Bot
parent dcc40a6267
commit dd9959ab0e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ReactCommon/cxxreact/JSBigString.cpp
View File

@@ -52,7 +52,7 @@ JSBigFileString::~JSBigFileString() {
const char *JSBigFileString::c_str() const {
if (!m_data) {
m_data =
(const char *) mmap(0, m_size, PROT_READ, MAP_SHARED, m_fd, m_mapOff);
(const char *) mmap(0, m_size, PROT_READ, MAP_PRIVATE, m_fd, m_mapOff);
CHECK(m_data != MAP_FAILED)
<< " fd: " << m_fd
<< " size: " << m_size