kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-02-08 22:42:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't automatically render more rows when dataSource updates

Browse Source 
Reviewed By: sahrens

Differential Revision: D2875678

fb-gh-sync-id: c10e2c65c133d01245ac134170b25cb93377f97b
This commit is contained in:
Pieter De Baets
2016-02-05 11:08:59 -08:00
committed by facebook-github-bot-4
parent fa2b53166e
commit d2ab6cabd4
1 changed files with 7 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
Libraries/CustomComponents/ListView/ListView.js
View File

@@ -35,7 +35,6 @@ var StaticRenderer = require('StaticRenderer');
var TimerMixin = require('react-timer-mixin');
var isEmpty = require('isEmpty');
var logError = require('logError');
var merge = require('merge');
var PropTypes = React.PropTypes;
@@ -292,26 +291,20 @@ var ListView = React.createClass({
},
componentWillReceiveProps: function(nextProps) {
if (this.props.dataSource !== nextProps.dataSource) {
if (this.props.dataSource !== nextProps.dataSource ||
this.props.initialListSize !== nextProps.initialListSize) {
this.setState((state, props) => {
this._prevRenderedRowsCount = 0;
return {
curRenderedRowsCount: Math.min(
state.curRenderedRowsCount + props.pageSize,
Math.max(
state.curRenderedRowsCount,
props.initialListSize
),
props.dataSource.getRowCount()
),
};
});
}
if (this.props.initialListSize !== nextProps.initialListSize) {
this.setState((state, props) => {
return {
curRenderedRowsCount: Math.max(
state.curRenderedRowsCount,
props.initialListSize
),
};
});
}, () => this._renderMoreRowsIfNeeded());
}
},