kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-03 22:48:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup a bunch of the JS stuff

Browse Source 
Summary: Stricter flow typing, better naming, modularization with context objects, more extensible, etc.

Reviewed By: yungsters

Differential Revision: D10443440

fbshipit-source-id: 171358dfb105829b872d6379064ba4bc29ce34de
This commit is contained in:
Spencer Ahrens
2018-11-05 15:32:47 -08:00
committed by Facebook Github Bot
parent 7b5277bb75
commit ccc8a425ad
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ReactCommon/fabric/uimanager/ReactBytecodeInterpreter.cpp
View File

@@ -55,7 +55,7 @@ SharedShadowNode ReactBytecodeInterpreter::runCommand(
componentDescriptorRegistry[parentShadowNode];
componentDescriptor->appendChild(parentShadowNode, nodes[tag]);
}
} else if (opcode == "childSetNode") {
} else if (opcode == "returnRoot") {
LOG(INFO)
<< "(stop) UITemplateProcessor inject serialized 'server rendered' view tree";
return nodes[command[1].asInt()];
@@ -138,9 +138,9 @@ SharedShadowNode ReactBytecodeInterpreter::buildShadowTree(
<< folly::toJson(command) << "': '" << e.what() << "'";
}
}
LOG(ERROR) << "react ui template missing childSetNode command :(";
LOG(ERROR) << "react ui template missing returnRoot command :(";
throw std::runtime_error(
"Missing childSetNode command in template content:\n" + content);
"Missing returnRoot command in template content:\n" + content);
return SharedShadowNode{};
}

4
ReactCommon/fabric/uimanager/tests/ReactBytecodeInterpreterTest.cpp
View File

@@ -75,7 +75,7 @@ TEST(ReactBytecodeInterpreterTest, testSimpleBytecode) {
auto bytecode = R"delim({"version":0.1,"commands":[
["createNode",2,"RCTView",-1,{"opacity": 0.5, "testId": "root"}],
["createNode",4,"RCTView",2,{"testId": "child"}],
["childSetNode",2]
["returnRoot",2]
]})delim";
mockSimpleTestValue_ = true;
@@ -110,7 +110,7 @@ TEST(ReactBytecodeInterpreterTest, testConditionalBytecode) {
[["createNode",4,"RCTView",2,{"testId": "cond_true"}]],
[["createNode",4,"RCTView",2,{"testId": "cond_false"}]]
],
["childSetNode",2]
["returnRoot",2]
]})delim";
mockSimpleTestValue_ = true;