kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-03-06 22:37:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Removed unnecessary call in RootShadowNode::clone

Browse Source 
Summary: The removed code does nothing because we are replacing the oldChild with newChild several lines above.

Reviewed By: JoshuaGross

Differential Revision: D14402637

fbshipit-source-id: 731a950f373e20f7d5bae3cbf6470335d3694ccc
This commit is contained in:
Valentin Shergin
2019-03-18 23:38:11 -07:00
committed by Facebook Github Bot
parent 50b40a41c0
commit b93221036a
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ReactCommon/fabric/components/root/RootShadowNode.cpp
View File

@@ -70,8 +70,6 @@ UnsharedRootShadowNode RootShadowNode::clone(
/* .children = */ sharedChildren,
});
newParent->replaceChild(oldChild, newChild);
oldChild = oldParent;
newChild = newParent;
}