kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-01-12 22:50:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

TM Android: temporarily disable callback support to unbreak build

Browse Source 
Summary: With the recent change, JSCallInvoker now expects `Instance` to be passed in, not just the `MessageQueueThread`. There needs to be more plumbing to get the instance of `Instance` from the Java side, but this commit is just to unbreak the build temporarily.

Reviewed By: JoshuaGross

Differential Revision: D14687622

fbshipit-source-id: 42e0173ee8336fc5660fe8188a1e1f8517611521
This commit is contained in:
Kevin Gozali
2019-03-29 12:29:00 -07:00
committed by Facebook Github Bot
parent 366fa2f1ef
commit a47746b851
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni/TurboModuleManager.cpp
View File

@@ -55,7 +55,8 @@ void TurboModuleManager::installJSIBindings() {
TurboModuleBinding::install(*runtime_, std::make_shared<TurboModuleBinding>(
[this](const std::string &name) {
const auto moduleInstance = getJavaModule(name);
const auto jsInvoker = std::make_shared<react::JSCallInvoker>(jsMessageQueueThread_);
// TODO: Pass in react Instance to JSCallInvoker instead.
const auto jsInvoker = std::make_shared<react::JSCallInvoker>(nullptr);
return moduleProvider_(name, moduleInstance, jsInvoker);
})
);