kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-27 19:25:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

TM iOS: allow fallback __turbo__* methods to proxy NSDictionary types to stricter types

Browse Source 
Summary:
Some modules may have args with types stricter than just `NSDictionary`. For now, allow these modules to manually define a __turbo__* variant of the same method that receives basic NSDictionary/NSArray typed args. That helper method can do the conversion to the stricter type as necessary. This is only needed during migration phase of TurboModule.

Without this workaround, existing methods may get unrecognized selector errors.

Reviewed By: PeteTheHeat

Differential Revision: D14115981

fbshipit-source-id: ca7fcf497490ef9cce14c3d3444991c50d3cb550
This commit is contained in:
Kevin Gozali
2019-02-15 20:03:19 -08:00
committed by Facebook Github Bot
parent cd778873f0
commit a1b3421d10
1 changed files with 31 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
ReactCommon/turbomodule/core/platform/ios/RCTTurboModule.mm
View File

@@ -281,32 +281,54 @@ SEL resolveMethodSelector(
// PromiseKind expects 2 additional function args for resolve() and reject()
size_t adjustedCount = valueKind == PromiseKind ? argCount + 2 : argCount;
NSString *baseMethodName = [NSString stringWithUTF8String:methodName.c_str()];
// Notes:
// - This may be expensive lookup. The codegen output should specify the exact selector name.
// - Some classes may have strictly typed arg that isn't compatible with plain NSDictionary/NSArray. For those, allow a helper method
// with "__turbo__" prefix (hand-written) that can do the translation from plain NSDictionary/NSArray to the stricter type.
// This is only for migration purpose.
if (adjustedCount == 0) {
selector = NSSelectorFromString(baseMethodName);
if (![module respondsToSelector:selector]) {
throw std::runtime_error("Unable to find method: " + methodName + " for module: " + moduleName + ". Make sure the module is installed correctly.");
SEL turboSelector = NSSelectorFromString([NSString stringWithFormat:@"__turbo__%s", methodName.c_str()]);
if ([module respondsToSelector:turboSelector]) {
selector = turboSelector;
} else {
selector = NSSelectorFromString([NSString stringWithUTF8String:methodName.c_str()]);
if (![module respondsToSelector:selector]) {
throw std::runtime_error("Unable to find method: " + methodName + " for module: " + moduleName + ". Make sure the module is installed correctly.");
}
}
} else if (adjustedCount == 1) {
selector = NSSelectorFromString([NSString stringWithFormat:@"%@:", baseMethodName]);
if (![module respondsToSelector:selector]) {
throw std::runtime_error("Unable to find method: " + methodName + " for module: " + moduleName + ". Make sure the module is installed correctly.");
SEL turboSelector = NSSelectorFromString([NSString stringWithFormat:@"__turbo__%s:", methodName.c_str()]);
if ([module respondsToSelector:turboSelector]) {
selector = turboSelector;
} else {
selector = NSSelectorFromString([NSString stringWithFormat:@"%s:", methodName.c_str()]);
if (![module respondsToSelector:selector]) {
throw std::runtime_error("Unable to find method: " + methodName + " for module: " + moduleName + ". Make sure the module is installed correctly.");
}
}
} else {
// TODO: This may be expensive lookup. The codegen output should specify the exact selector name.
SEL turboSelector = nil;
unsigned int numberOfMethods;
Method *methods = class_copyMethodList([module class], &numberOfMethods);
if (methods) {
NSString *methodPrefix = [NSString stringWithFormat:@"%s:", methodName.c_str()];
NSString *turboMethodPrefix = [NSString stringWithFormat:@"__turbo__%s:", methodName.c_str()];
for (unsigned int i = 0; i < numberOfMethods; i++) {
SEL s = method_getName(methods[i]);
if ([NSStringFromSelector(s) hasPrefix:[NSString stringWithFormat:@"%@:", baseMethodName]]) {
NSString *objcMethodName = NSStringFromSelector(s);
if ([objcMethodName hasPrefix:methodPrefix]) {
selector = s;
} else if ([objcMethodName hasPrefix:turboMethodPrefix]) {
turboSelector = s;
break;
}
}
free(methods);
}
if (turboSelector) {
selector = turboSelector;
}
if (!selector) {
throw std::runtime_error("Unable to find method: " + methodName + " for module: " + moduleName + ". Make sure the module is installed correctly.");
}