Turn off static linking for cxxreact:bridge

Summary: Remove `force_static=true` from cxxreact:bridge, add dependencies to targets that were pulling them in from a statically linked cxxreact:bridge.

Reviewed By: mhorowitz

Differential Revision: D12914861

fbshipit-source-id: ff335b70e80d014538a8d5dc8c0bb7b095e7940e
This commit is contained in:
Chris Tolliday
2018-11-08 22:31:24 -08:00
committed by Facebook Github Bot
parent d6236796b2
commit 918a7d5b70
4 changed files with 5 additions and 1 deletions

View File

@@ -56,7 +56,9 @@ rn_xplat_cxx_library(
"fbandroid//xplat/fbgloginit:fbgloginit",
"xplat//fbsystrace:fbsystrace",
react_native_xplat_target("cxxreact:bridge"),
react_native_xplat_target("cxxreact:jsbigstring"),
react_native_xplat_target("cxxreact:module"),
react_native_xplat_target("jsinspector:jsinspector"),
react_native_xplat_dep("jsi:jsi"),
FBJNI_TARGET,
]) if not IS_OSS_BUILD else [],

View File

@@ -125,7 +125,6 @@ rn_xplat_cxx_library(
fbobjc_compiler_flags = get_apple_compiler_flags(),
fbobjc_force_static = True,
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
force_static = True,
macosx_tests_override = [],
platforms = (ANDROID, APPLE),
preprocessor_flags = [

View File

@@ -27,6 +27,7 @@ jni_instrumentation_test_lib(
"fbandroid//instrumentation_tests/...",
],
deps = [
"xplat//folly:dynamic",
"xplat//third-party/gmock:gtest",
"xplat//third-party/linker_lib:android",
"xplat//third-party/linker_lib:atomic",

View File

@@ -32,8 +32,10 @@ cxx_library(
],
xcode_public_headers_symlinks = True,
deps = [
"xplat//fbsystrace:fbsystrace",
react_native_xplat_dep("jsi:jsi"),
react_native_xplat_dep("jsi:JSIDynamic"),
react_native_xplat_target("cxxreact:bridge"),
react_native_xplat_target("cxxreact:jsbigstring"),
],
)