kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-01-12 22:50:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix tests with JavaOnlyMap

Browse Source 
Summary: Need to force the double thing in more places.

Reviewed By: cpojer

Differential Revision: D14835792

fbshipit-source-id: fb7a5435675b322d5fbbe9858e08804e9abe65db
This commit is contained in:
Spencer Ahrens
2019-04-08 23:03:26 -07:00
committed by Facebook Github Bot
parent 742d02a172
commit 8ec13c306c
3 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ReactAndroid/src/main/java/com/facebook/react/bridge/JavaOnlyArray.java
View File

@@ -156,7 +156,7 @@ public class JavaOnlyArray implements ReadableArray, WritableArray {
@Override
public void pushInt(int value) {
mBackingList.add(value);
mBackingList.add(new Double(value));
}
@Override

2
ReactAndroid/src/main/java/com/facebook/react/bridge/JavaOnlyMap.java
View File

@@ -183,7 +183,7 @@ public class JavaOnlyMap implements ReadableMap, WritableMap {
@Override
public void putInt(@Nonnull String key, int value) {
mBackingMap.put(key, value);
mBackingMap.put(key, new Double(value));
}
@Override

24
ReactAndroid/src/test/java/com/facebook/react/modules/timing/TimingModuleTest.java
View File

@@ -129,7 +129,7 @@ public class TimingModuleTest {
mTiming.onHostResume();
mTiming.createTimer(1, 1, 0, false);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(1));
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(1.0));
reset(mJSTimersMock);
stepChoreographerFrame();
verifyNoMoreInteractions(mJSTimersMock);
@@ -140,11 +140,11 @@ public class TimingModuleTest {
mTiming.createTimer(100, 1, 0, true);
mTiming.onHostResume();
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(100));
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(100.0));
reset(mJSTimersMock);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(100));
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(100.0));
}
@Test
@@ -153,7 +153,7 @@ public class TimingModuleTest {
mTiming.createTimer(105, 1, 0, true);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(105));
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(105.0));
reset(mJSTimersMock);
mTiming.deleteTimer(105);
@@ -167,7 +167,7 @@ public class TimingModuleTest {
mTiming.createTimer(41, 1, 0, true);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41));
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
reset(mJSTimersMock);
mTiming.onHostPause();
@@ -177,7 +177,7 @@ public class TimingModuleTest {
reset(mJSTimersMock);
mTiming.onHostResume();
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41));
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
}
@Test
@@ -187,7 +187,7 @@ public class TimingModuleTest {
mTiming.createTimer(41, 1, 0, true);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41));
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
reset(mJSTimersMock);
mTiming.onHeadlessJsTaskFinish(42);
@@ -202,12 +202,12 @@ public class TimingModuleTest {
mTiming.createTimer(41, 1, 0, true);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41));
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
reset(mJSTimersMock);
mTiming.onHeadlessJsTaskFinish(42);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41));
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
reset(mJSTimersMock);
mTiming.onHostPause();
@@ -222,13 +222,13 @@ public class TimingModuleTest {
mTiming.onHostPause();
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41));
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
reset(mJSTimersMock);
mTiming.onHostResume();
mTiming.onHeadlessJsTaskFinish(42);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41));
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
reset(mJSTimersMock);
mTiming.onHostPause();
@@ -239,7 +239,7 @@ public class TimingModuleTest {
@Test
public void testSetTimeoutZero() {
mTiming.createTimer(100, 0, 0, false);
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(100));
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(100.0));
}
@Test