kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-01-12 22:50:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Fixed a bug in Diffing algorithm

Browse Source 
Summary: Before the fix, the algorithm compares ShadowViews to make a decision should it recursively call itself or not; that didn't work properly because a ShadowView doesn't fully represent the state of the subtree tree (e.g. they don't have information about children nodes). After the fix, we compare pointers to ShadowNodes (by comparing pairs).

Reviewed By: mdvacca

Differential Revision: D14696996

fbshipit-source-id: 560d623b15a272f13b08a11745dec6be39a5dbdd
This commit is contained in:
Valentin Shergin
2019-03-30 12:18:47 -07:00
committed by Facebook Github Bot
parent 0b3f99bf93
commit 5a418c5a5d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ReactCommon/fabric/mounting/Differentiator.cpp
View File

@@ -152,7 +152,7 @@ static void calculateShadowViewMutations(
// We have to call the algorithm recursively if the inserted view
// is *not* the same as removed one.
const auto &newChildPair = it->second;
if (newChildPair.shadowView != oldChildPair.shadowView) {
if (newChildPair != oldChildPair) {
const auto oldGrandChildPairs =
sliceChildShadowNodeViewPairs(*oldChildPair.shadowNode);
const auto newGrandChildPairs =