kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-01 22:41:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix test suite when running on a feature branch

Browse Source 
Summary:
Test suite for React Native version check relies on `ReactNativeVersion.js` file that is modified on a release branch (it contains values of a real version, not zeros).

That makes it impossible for the build to pass: https://circleci.com/gh/facebook/react-native/23494

This PR mocks it with zero values, just like we mock it in other suites. I am not sure if that is desired, but works for now.

CC ide
Closes https://github.com/facebook/react-native/pull/16464

Differential Revision: D6100285

Pulled By: hramos

fbshipit-source-id: 784f7e14f5283403f3fa518940565e1ef19dd398
This commit is contained in:
Mike Grabowski
2017-10-19 13:44:28 -07:00
committed by Facebook Github Bot
parent f134de532a
commit 4e1dfa48a2
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/Core/__tests__/ReactNativeVersionCheck-test.js
View File

@@ -41,7 +41,7 @@ function _defineCheckVersionTests() {
});
it('passes when all the versions are zero', () => {
jest.dontMock('ReactNativeVersion');
_mockJsVersion(0, 0, 0);
_mockNativeVersion(0, 0, 0);
const ReactNativeVersion = require('ReactNativeVersion');