kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-01-12 22:50:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Fixing a typo/error in ConcreteState

Browse Source 
Summary: I don't recall why the mutation function return rvalue reference, but it is totally incorrect (the function cannot own the object, so returning a reference introducing a dungling pointer and will crash).

Reviewed By: mdvacca

Differential Revision: D15156312

fbshipit-source-id: 497d10de22a41906efe71cd10139e3710ae11a79
This commit is contained in:
Valentin Shergin
2019-05-07 19:12:26 -07:00
committed by Facebook Github Bot
parent fd6386a07e
commit 3238d3d3b4
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ReactCommon/fabric/core/state/ConcreteState.h
View File

@@ -66,7 +66,7 @@ class ConcreteState : public State {
* of conflict.
*/
void updateState(
std::function<Data && (const Data &oldData)> callback,
std::function<Data(const Data &oldData)> callback,
EventPriority priority = EventPriority::AsynchronousBatched) const {
stateCoordinator_->dispatchRawState(
{[stateCoordinator = stateCoordinator_,