kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-10 10:00:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Redbox: skip column number if it is 0 in Android.

Browse Source 
Summary:
As for symbolicated stack trace in the red box in Android, make column number not shown if it's zero.

Format Before:
{F61180667}

Format After:
{F61180666}

Reviewed By: mkonicek

Differential Revision: D3358317

fbshipit-source-id: 87981e678e22ab9f483727002175c8835941ceee
This commit is contained in:
Siqi Liu
2016-05-27 07:43:22 -07:00
committed by Facebook Github Bot 8
parent c82856fb7a
commit 26d3af3421
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxDialog.java
View File

@@ -124,7 +124,8 @@ import org.json.JSONObject;
FrameViewHolder holder = (FrameViewHolder) convertView.getTag();
holder.mMethodView.setText(frame.getMethod());
final int column = frame.getColumn();
final String columnString = column < 0 ? "" : ":" + column;
// If the column is 0, don't show it in red box.
final String columnString = column <= 0 ? "" : ":" + column;
holder.mFileView.setText(frame.getFileName() + ":" + frame.getLine() + columnString);
return convertView;
}