From 26d3af3421f0768cc2d4aeb354068ace3f7581e3 Mon Sep 17 00:00:00 2001 From: Siqi Liu Date: Fri, 27 May 2016 07:43:22 -0700 Subject: [PATCH] Redbox: skip column number if it is 0 in Android. Summary: As for symbolicated stack trace in the red box in Android, make column number not shown if it's zero. Format Before: {F61180667} Format After: {F61180666} Reviewed By: mkonicek Differential Revision: D3358317 fbshipit-source-id: 87981e678e22ab9f483727002175c8835941ceee --- .../main/java/com/facebook/react/devsupport/RedBoxDialog.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxDialog.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxDialog.java index eefb1d735..914f8db57 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxDialog.java +++ b/ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxDialog.java @@ -124,7 +124,8 @@ import org.json.JSONObject; FrameViewHolder holder = (FrameViewHolder) convertView.getTag(); holder.mMethodView.setText(frame.getMethod()); final int column = frame.getColumn(); - final String columnString = column < 0 ? "" : ":" + column; + // If the column is 0, don't show it in red box. + final String columnString = column <= 0 ? "" : ":" + column; holder.mFileView.setText(frame.getFileName() + ":" + frame.getLine() + columnString); return convertView; }