kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-03-06 17:34:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: DEBUG-only check for type match in ContextContainer

Browse Source 
Summary: Additional check verifies that requested type matches the type of a stored value.

Reviewed By: mdvacca

Differential Revision: D14944336

fbshipit-source-id: 6d3a1654d9b9a64ced83f553236093f02f2c97c7
This commit is contained in:
Valentin Shergin
2019-04-22 08:33:06 -07:00
committed by Facebook Github Bot
parent 758eb9fa7b
commit 2688780394
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ReactCommon/utils/ContextContainer.h
View File

@@ -22,7 +22,7 @@ namespace react {
*/
class ContextContainer final {
public:
using Shared = std::shared_ptr<const ContextContainer>;
using Shared = std::shared_ptr<ContextContainer const>;
/*
* Registers an instance of the particular type `T` in the container
@@ -42,6 +42,10 @@ class ContextContainer final {
instances_.find(key) == instances_.end() &&
"ContextContainer already had instance for given key.");
instances_.insert({key, std::make_shared<T>(instance)});
#ifndef NDEBUG
typeHashes_.insert({key, typeid(T).hash_code()});
#endif
}
/*
@@ -55,6 +59,9 @@ class ContextContainer final {
assert(
instances_.find(key) != instances_.end() &&
"ContextContainer doesn't have an instance for given key.");
assert(
typeHashes_.at(key) == typeid(T).hash_code() &&
"ContextContainer stores an instance of different type for given key.");
return *std::static_pointer_cast<T>(instances_.at(key));
}
@@ -62,6 +69,9 @@ class ContextContainer final {
mutable better::shared_mutex mutex_;
// Protected by mutex_`.
mutable better::map<std::string, std::shared_ptr<void>> instances_;
#ifndef NDEBUG
mutable better::map<std::string, size_t> typeHashes_;
#endif
};
} // namespace react