Fabric: Removing leftovers from previous implementation of view preallocation infra

Summary: Now it's implementled differently (see -[RCTComponentViewRegistry preallocateViewComponents]), so this code is not being used.

Reviewed By: mdvacca

Differential Revision: D15242045

fbshipit-source-id: c02eceb978cf1eae778f84a73456e7156ccf503b
This commit is contained in:
Valentin Shergin
2019-05-09 14:56:40 -07:00
committed by Facebook Github Bot
parent 8c0ba25f19
commit 1d985b5e6e
4 changed files with 0 additions and 26 deletions

View File

@@ -32,13 +32,6 @@ NS_ASSUME_NONNULL_BEGIN
*/
- (void)scheduleTransaction:(facebook::react::MountingCoordinator::Shared const &)mountingCoordinator;
/**
* Suggests preliminary creation of a component view of given type.
* The receiver is free to ignore the request.
* Can be called from any thread.
*/
- (void)optimisticallyCreateComponentViewWithComponentHandle:(facebook::react::ComponentHandle)componentHandle;
- (void)synchronouslyUpdateViewOnUIThread:(ReactTag)reactTag
changedProps:(NSDictionary *)props
componentDescriptor:(const facebook::react::ComponentDescriptor &)componentDescriptor;

View File

@@ -260,16 +260,4 @@ static void RNPerformMountInstructions(ShadowViewMutationList const &mutations,
[componentView updateProps:newProps oldProps:oldProps];
}
- (void)optimisticallyCreateComponentViewWithComponentHandle:(ComponentHandle)componentHandle
{
if (RCTIsMainQueue()) {
// There is no reason to allocate views ahead of time on the main thread.
return;
}
RCTExecuteOnMainQueue(^{
[self->_componentViewRegistry optimisticallyCreateComponentViewWithComponentHandle:componentHandle];
});
}
@end

View File

@@ -27,8 +27,6 @@ NS_ASSUME_NONNULL_BEGIN
- (void)schedulerDidFinishTransaction:(facebook::react::MountingCoordinator::Shared const &)mountingCoordinator;
- (void)schedulerOptimisticallyCreateComponentViewWithComponentHandle:(facebook::react::ComponentHandle)componentHandle;
@end
/**

View File

@@ -311,11 +311,6 @@ using namespace facebook::react;
[_mountingManager scheduleTransaction:mountingCoordinator];
}
- (void)schedulerOptimisticallyCreateComponentViewWithComponentHandle:(ComponentHandle)componentHandle
{
[_mountingManager optimisticallyCreateComponentViewWithComponentHandle:componentHandle];
}
- (void)addObserver:(id<RCTSurfacePresenterObserver>)observer
{
std::unique_lock<better::shared_mutex> lock(_observerListMutex);