kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-01-12 22:50:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Removing of all unnececery nil checks in RCTMountingManager

Browse Source 
Summary: We needed that in the very beginning when diffing algorithm produces mount instructions for <Text> nodes which don't have ComponentView representation, so we simply silence those error here. That's not the case anymore, so we don't need those ugly checks.

Reviewed By: JoshuaGross

Differential Revision: D15296473

fbshipit-source-id: ea3717062056907e5395776fe95e3d581d3e9b09
This commit is contained in:
Valentin Shergin
2019-05-10 15:31:00 -07:00
committed by Facebook Github Bot
parent 9e3856fd99
commit 16499c1086
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
React/Fabric/Mounting/RCTMountingManager.mm
View File

@@ -36,10 +36,7 @@ static void RNDeleteMountInstruction(ShadowViewMutation const &mutation, RCTComp
auto const &oldChildShadowView = mutation.oldChildShadowView;
UIView<RCTComponentViewProtocol> *componentView = [registry componentViewByTag:oldChildShadowView.tag];
// TODO(shergin): Make sure that we don't need this check anymore and delete it.
if (componentView == nil) {
return;
}
assert(componentView != nil && "Attempt to delete unregistered component.");
[registry enqueueComponentViewWithComponentHandle:oldChildShadowView.componentHandle
tag:oldChildShadowView.tag
@@ -55,10 +52,8 @@ static void RNInsertMountInstruction(ShadowViewMutation const &mutation, RCTComp
UIView<RCTComponentViewProtocol> *childComponentView = [registry componentViewByTag:newShadowView.tag];
UIView<RCTComponentViewProtocol> *parentComponentView = [registry componentViewByTag:parentShadowView.tag];
// TODO(shergin): Make sure that we don't need this check anymore and delete it.
if (childComponentView == nil || parentComponentView == nil) {
return;
}
assert(childComponentView != nil && "Attempt to mount unregistered component.");
assert(parentComponentView != nil && "Attempt to mount into unregistered component.");
[parentComponentView mountChildComponentView:childComponentView index:mutation.index];
}
@@ -72,10 +67,8 @@ static void RNRemoveMountInstruction(ShadowViewMutation const &mutation, RCTComp
UIView<RCTComponentViewProtocol> *childComponentView = [registry componentViewByTag:oldShadowView.tag];
UIView<RCTComponentViewProtocol> *parentComponentView = [registry componentViewByTag:parentShadowView.tag];
// TODO(shergin): Make sure that we don't need this check anymore and delete it.
if (childComponentView == nil || parentComponentView == nil) {
return;
}
assert(childComponentView != nil && "Attempt to unmount unregistered component.");
assert(parentComponentView != nil && "Attempt to unmount from unregistered component.");
[parentComponentView unmountChildComponentView:childComponentView index:mutation.index];
}