kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-03-06 22:37:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Using #ifndef NDEBUG instead of #ifdef DEBUG

Browse Source 
Summary:
Trivial.
Apparently, `DEBUG` is non-standard feature and using `assert` with `DEBUG` is practically asking for bugs. So, if your `assert` relies on some variable which is only defined when `DEBUG` is set, it's easy to get invalid code because NDEBUG and DEBUG can be unsync.
So, we have to use clunky double negative `#ifndef NDEBUG` everywhere where we used DEBUG.

Reviewed By: JoshuaGross

Differential Revision: D15031328

fbshipit-source-id: 036f573e68925741ca46384261885766c87db1e3
This commit is contained in:
Valentin Shergin
2019-04-23 15:08:51 -07:00
committed by Facebook Github Bot
parent 2c0af4b317
commit 11439eabfc
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ReactCommon/fabric/mounting/ShadowTree.h
View File

@@ -5,7 +5,7 @@
#pragma once
#ifdef DEBUG
#ifndef NDEBUG
#define RN_SHADOW_TREE_INTROSPECTION
#endif