kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-01-12 22:50:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Require passing in JSCallInvokerHolder to TurboModuleManager

Browse Source 
Summary: Right now TurboModuleManager gets the JSCallInvokerHolder from the bridge in its constructor; this diff changes the constructor to make the JSCallInvokerHolder a required argument so that TurboModuleManager doesn't directly depend on the bridge.

Reviewed By: axe-fb, RSNara

Differential Revision: D15227184

fbshipit-source-id: b16e6abaa727587986a132d0e124163acdf55408
This commit is contained in:
Emily Janzer
2019-05-09 11:21:36 -07:00
committed by Facebook Github Bot
parent 335c81ec31
commit 078f14c5d2
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java
View File

@@ -13,6 +13,7 @@ import com.facebook.react.bridge.JSIModule;
import com.facebook.react.bridge.JavaScriptContextHolder;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.queue.MessageQueueThread;
import com.facebook.react.turbomodule.core.interfaces.JSCallInvokerHolder;
import com.facebook.react.turbomodule.core.interfaces.TurboModule;
import com.facebook.soloader.SoLoader;
@@ -34,16 +35,11 @@ public class TurboModuleManager implements JSIModule {
private final HybridData mHybridData;
public TurboModuleManager(
ReactApplicationContext reactApplicationContext, JavaScriptContextHolder jsContext, TurboModuleManagerDelegate tmmDelegate) {
ReactApplicationContext reactApplicationContext, JavaScriptContextHolder jsContext, TurboModuleManagerDelegate tmmDelegate, JSCallInvokerHolder instanceHolder) {
mReactApplicationContext = reactApplicationContext;
JSCallInvokerHolderImpl instanceHolder =
(JSCallInvokerHolderImpl) mReactApplicationContext
.getCatalystInstance()
.getJSCallInvokerHolder();
mHybridData = initHybrid(jsContext.get(), instanceHolder, tmmDelegate);
mHybridData = initHybrid(jsContext.get(), (JSCallInvokerHolderImpl) instanceHolder, tmmDelegate);
mTurbomoduleManagerDelegate = tmmDelegate;
}
@DoNotStrip
@SuppressWarnings("unused")
private TurboModule getJavaModule(String name) {