kylefang/react-native-web
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-web.git synced 2026-03-27 01:34:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

[fix] AppRegistry.getApplication shouldn't throw if missing options

Browse Source 
Fix #899
This commit is contained in:
Nicolas Gallagher
2018-04-21 12:05:42 -07:00
parent 38affa9bae
commit c6e2b584af
3 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/react-native-web/src/exports/AppRegistry/__tests__/index-test.js vendored
View File

@@ -22,6 +22,11 @@ describe('AppRegistry', () => {
ExecutionEnvironment.canUseDOM = canUseDOM;
});
test('does not throw when missing appParameters', () => {
AppRegistry.registerComponent('App', () => RootComponent);
expect(() => AppRegistry.getApplication('App')).not.toThrow();
});
test('returns "element" and "getStyleElement"', () => {
AppRegistry.registerComponent('App', () => RootComponent);

4
packages/react-native-web/src/exports/AppRegistry/index.js vendored
View File

@@ -58,7 +58,7 @@ export default class AppRegistry {
getApplication: appParameters =>
getApplication(
componentProviderInstrumentationHook(componentProvider),
appParameters.initialProps || emptyObject,
appParameters ? appParameters.initialProps : emptyObject,
wrapperComponentProvider && wrapperComponentProvider(appParameters)
),
run: appParameters =>
@@ -90,7 +90,7 @@ export default class AppRegistry {
return appKey;
}
static runApplication(appKey: string, appParameters?: Object): void {
static runApplication(appKey: string, appParameters: Object): void {
const isDevelopment = process.env.NODE_ENV !== 'production';
const params = { ...appParameters };
params.rootTag = `#${params.rootTag.id}`;

2
website/storybook/2-apis/AppRegistry/AppRegistryScreen.js
View File

@@ -93,7 +93,7 @@ const AppRegistryScreen = () => (
})`
}}
name="static runApplication"
typeInfo="(appKey: string, appParameters?: object) => void"
typeInfo="(appKey: string, appParameters: object) => void"
/>
<DocItem