Commit Graph

2424 Commits

Author SHA1 Message Date
Erik Haider Forsén
04fba7900a Corrects flow return type (#1703)
<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request properly. -->
<!-- If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. -->
<!-- Please esure you've also read the `/CONTRIBUTING.md` guide. -->

### Summary
Using `firebase.links().createShortLink()` returns a promise with a string wrapper object. As far as I can tell, there is no reason it can not be a string literal, witch (to me) seems more logical (it is also the return type of the underlying function call).
### Checklist

- [x] Supports `Android`
- [x] Supports `iOS`
- [ ] `e2e` tests added or updated in [/tests/e2e/\*](/tests/e2e)
- [ ] Updated the documentation in the [docs repo](https://github.com/invertase/react-native-firebase-docs)
  - **LINK TO DOCS PR HERE**
- [x] Flow types updated
- [ ] Typescript types updated

### Test Plan
Tested locally, works for me. 
<!-- Demonstrate the code is solid. -->
<!-- Example: The exact testing commands you ran and their final output (e.g. screenshot of test summary). -->
<!-- Example: Screenshots / videos if the pull request changes UI related code such as Notifications or Admob -->

### Release Plan

<!-- Help reviewers and the release process by writing your own release notes. See below for examples. -->

[TYPES][ENHANCEMENT] [LINKS] - Corrects flow return type to string literal instead of string wrapper

<!--
  **INTERNAL tagged notes will not be included in the next version's release notes.**

    CATEGORY
  [----------]      TYPE
  [ TYPES    ] [-------------]       LOCATION
  [ JS       ] [ BREAKING    ] [------------------]
  [ GENERAL  ] [ BUGFIX      ] [ {FirebaseModule} ]
  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}       ]
  [ IOS      ] [ FEATURE     ] [ {Directory}      ]   |-----------|
  [ ANDROID  ] [ MINOR       ] [ {Framework}      ] - | {Message} |
  [----------] [-------------] [------------------]   |-----------|

 EXAMPLES:

 [IOS] [ANDROID] [BREAKING] [AUTHENTICATION] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [FIRESTORE] - Did a thing to fix a thing with a Firestore thing
 [JS] [BREAKING] - Remove a deprecated thing
 [TYPES] [ENHANCEMENT] [NOTIFICATIONS] - Update flow types for a thing in notifications
 [JS] [ENHANCEMENT] - Expose export of a internal thing utility for public usage
 [INTERNAL] [FEATURE] [./utils] - Added an internal util to make doing a thing easier
-->

---

Think `react-native-firebase` is great? Please consider supporting the project with any of the below:

- 👉 Donate via [Open Collective](https://opencollective.com/react-native-firebase/donate)
- 👉 Follow [`React Native Firebase`](https://twitter.com/rnfirebase) and [`Invertase`](https://twitter.com/invertaseio) on Twitter
- 👉 Star this repo on GitHub ️
- 👉 Contribute; see our [contributing guide](/CONTRIBUTING.md)

🔥
2018-11-23 13:56:50 +00:00
Tim Wang
a735d271be Add setUserProperties to index.d.ts (#1699)
<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request properly. -->
<!-- If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. -->
<!-- Please esure you've also read the `/CONTRIBUTING.md` guide. -->

### Summary

<!-- Explain the **motivation** for making this change e.g. what existing problem does the pull request solve? -->

Add setUserProperties to TypeScript typing file.

Source code at https://github.com/invertase/react-native-firebase/blob/master/src/modules/analytics/index.js#L154

### Checklist

- [ ] Supports `Android`
- [ ] Supports `iOS`
- [ ] `e2e` tests added or updated in [/tests/e2e/\*](/tests/e2e)
- [ ] Updated the documentation in the [docs repo](https://github.com/invertase/react-native-firebase-docs)
  - **LINK TO DOCS PR HERE**
- [ ] Flow types updated
- [x] Typescript types updated

### Test Plan

<!-- Demonstrate the code is solid. -->
<!-- Example: The exact testing commands you ran and their final output (e.g. screenshot of test summary). -->
<!-- Example: Screenshots / videos if the pull request changes UI related code such as Notifications or Admob -->

### Release Plan

<!-- Help reviewers and the release process by writing your own release notes. See below for examples. -->

[TYPES] [BUGFIX] [ANALYTICS] Add setUserProperties TS typing.

<!--
  **INTERNAL tagged notes will not be included in the next version's release notes.**

    CATEGORY
  [----------]      TYPE
  [ TYPES    ] [-------------]       LOCATION
  [ JS       ] [ BREAKING    ] [------------------]
  [ GENERAL  ] [ BUGFIX      ] [ {FirebaseModule} ]
  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}       ]
  [ IOS      ] [ FEATURE     ] [ {Directory}      ]   |-----------|
  [ ANDROID  ] [ MINOR       ] [ {Framework}      ] - | {Message} |
  [----------] [-------------] [------------------]   |-----------|

 EXAMPLES:

 [IOS] [ANDROID] [BREAKING] [AUTHENTICATION] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [FIRESTORE] - Did a thing to fix a thing with a Firestore thing
 [JS] [BREAKING] - Remove a deprecated thing
 [TYPES] [ENHANCEMENT] [NOTIFICATIONS] - Update flow types for a thing in notifications
 [JS] [ENHANCEMENT] - Expose export of a internal thing utility for public usage
 [INTERNAL] [FEATURE] [./utils] - Added an internal util to make doing a thing easier
-->

---

Think `react-native-firebase` is great? Please consider supporting the project with any of the below:

- 👉 Donate via [Open Collective](https://opencollective.com/react-native-firebase/donate)
- 👉 Follow [`React Native Firebase`](https://twitter.com/rnfirebase) and [`Invertase`](https://twitter.com/invertaseio) on Twitter
- 👉 Star this repo on GitHub ️
- 👉 Contribute; see our [contributing guide](/CONTRIBUTING.md)
2018-11-21 10:30:08 +01:00
Rakan Nimer
a19ed879a9 Increase test coverage of Realtime Database (#1694)
Add more tests for Realtime Database

### Summary

Increases test coverage, which should be helpful when starting work on v6.

### Checklist

- [x] `e2e` tests added or updated in [/tests/e2e/\*](/tests/e2e)

### Release Plan

[TESTING][ENHANCEMENT][Database] - More tests

Think `react-native-firebase` is great? Please consider supporting the project with any of the below:

- 👉 Donate via [Open Collective](https://opencollective.com/react-native-firebase/donate)
- 👉 Follow [`React Native Firebase`](https://twitter.com/rnfirebase) and [`Invertase`](https://twitter.com/invertaseio) on Twitter
- 👉 Star this repo on GitHub ️
- 👉 Contribute; see our [contributing guide](/CONTRIBUTING.md)
2018-11-20 14:53:15 +02:00
Daehoon Kim
716b49a9cd Fix authStateChanged after app is reloaded (fixes #1677) (#1698) 2018-11-20 12:13:56 +00:00
yernar
9486cdcc20 fixed #1687 (#1692) 2018-11-19 11:24:16 +00:00
Rakan Nimer
f2bf9c3179 Run prettier on index.d.ts & Add auth listener callback type (#1689)
### Summary

Ran prettier on index.d.ts and added AuthListenerCallback to typescript declaration file and pass it to auth listeners

### Checklist

- [ ] Supports `Android`
- [ ] Supports `iOS`
- [ ] `e2e` tests added or updated in [/tests/e2e/\*](/tests/e2e)
- [ ] Updated the documentation in the [docs repo](https://github.com/invertase/react-native-firebase-docs)
  - **LINK TO DOCS PR HERE**
- [ ] Flow types updated
- [x] Typescript types updated


### Release Plan

[TYPES][ENHANCEMENT] [AUTHENTICATION] - Update TS types for auth listeners

---

Think `react-native-firebase` is great? Please consider supporting the project with any of the below:

- 👉 Donate via [Open Collective](https://opencollective.com/react-native-firebase/donate)
- 👉 Follow [`React Native Firebase`](https://twitter.com/rnfirebase) and [`Invertase`](https://twitter.com/invertaseio) on Twitter
- 👉 Star this repo on GitHub ️
- 👉 Contribute; see our [contributing guide](/CONTRIBUTING.md)
2018-11-15 17:09:00 +02:00
Michael Diarmid
f16970060c Update README.md 2018-11-05 19:34:21 +00:00
Salakar
7b9898c973 5.1.0 2018-11-05 17:10:43 +00:00
Salakar
5b0282ed28 [core][android][ios] add app.delete() support 2018-11-05 16:46:06 +00:00
Salakar
ead0ca59be 5.1.0-rc3 2018-11-04 04:08:23 +00:00
Michael Diarmid
5120121797 [ios][android] Authentication improvements (#1663)
* [internals][js] nativeWithArgs wrapper incorrectly wrapping NativeModule constants - should only wrap functions

* [ios][android][js][auth] ensure user login state is consistent across RN reloads + tests

* remove test focus

* [android][auth] clear all auth state and id token listeners between React Native reloads

* [ios][auth] clear all auth state and id token listeners between React Native reloads

* [ios][auth] cleanup and add new auth error codes
2018-11-04 04:06:40 +00:00
Salakar
424d1e8f60 [tests][ios] update Firebase pods to ~>5.11.0 2018-11-01 13:39:42 +00:00
Salakar
a734d7b706 [android] update Firebase SDK dependencies 2018-11-01 13:12:17 +00:00
Salakar
cc3d8e74d8 [js][database] add support for exportVal() - #fixes 1497 2018-10-31 18:29:09 +01:00
Salakar
31fc0c4b77 5.1.0-rc2 2018-10-27 05:37:06 +01:00
Michael Diarmid
d3b9b24cca [android][database] database improvements (#1619)
- [ANDROID] [BUGFIX] [DATABASE] - Database listeners now correctly tearing down between RN reloads. (Fixes #1498 #1611 #1609)
 - [JS] [BUGFIX] [DATABASE] - Fixed an issue where `Reference.toString()` incorrectly contains `//` instead of `/` when joining the parent and child paths.
 - [JS] [BUGFIX] [DATABASE] - Rework `.push()` behaviour to match WebSDK and correctly return a Reference instance in all scenarios. (Fixes #893 #1464 #1572)
 - [JS] [ENHANCEMENT] [UTILS] - Added a `firebase.utils().database.cleanup()` utility method which removes all database listeners.
2018-10-27 05:34:09 +01:00
Salakar
210c966443 [ios][notifications] missing default case + typo 2018-10-26 20:06:07 +01:00
Michael Diarmid
b51be05383 Update Bug_report.md 2018-10-25 18:51:40 +01:00
Tim Wang
6858137563 Add IOSMessaging module for APNS specific methods (#1626)
[IOS] [FEATURE] [MESSAGING] - Add IOSMessaging module for APNS specific methods.
2018-10-25 06:12:52 +01:00
Michael Diarmid
7f691de29f Update Bug_report.md 2018-10-25 00:36:11 +01:00
Michael Diarmid
5508a3f644 Update Bug_report.md 2018-10-25 00:33:37 +01:00
Michael Diarmid
f48ee9a267 Update Bug_report.md 2018-10-25 00:25:40 +01:00
Tim Wang
4e8b65173b Fix IOSNotification badge type definition (#1630)
[TYPES] [BUGFIX] [NOTIFICATIONS] - Change IOSNotification badge type definition to number
2018-10-24 12:07:52 +01:00
Andrzej Lewandowski
44c7c92acf [Android][IOS][Firestore] add arrayRemove and arrayUnion to FieldValue (#1624)
### Summary

Add methods arrayRemove and arrayUnion to work with arrays in firestore.

Fixes #1389

### Checklist
* [x]  Supports `Android`
* [x]  Supports `iOS`
* [x]  `e2e` tests added or updated in [/tests/e2e/*](/tests/e2e)
* [x]  Updated the documentation in the [docs repo](https://github.com/invertase/react-native-firebase-docs)

https://github.com/invertase/react-native-firebase-docs/pull/134

* [x]  Flow types updated
* [x]  Typescript types updated
2018-10-23 13:40:11 +01:00
Michael Diarmid
991ed4f628 Update stale.yml 2018-10-23 10:13:25 +01:00
Salakar
7fe7f058ff update issue templates 2018-10-22 19:35:49 +01:00
Salakar
fbf38dbc6e update issue templates 2018-10-22 19:35:29 +01:00
Salakar
dee931e57d update issue templates 2018-10-22 19:31:58 +01:00
Salakar
400fd28e77 update issue templates 2018-10-22 18:48:20 +01:00
Salakar
48866fd45c update pull request template 2018-10-22 17:43:30 +01:00
Michael Diarmid
acd3a5a4e5 Update CONTRIBUTING.md 2018-10-22 14:50:14 +01:00
Michael Diarmid
1f4f9f68b6 Update README.md 2018-10-22 13:16:46 +01:00
Felipe Waku
bf3f5001a0 Returning null as downloadUrl in upload task (#1620)
solves: #1591 using the first solution:

> 1. Still consider the invocation a success, providing downloadURL as null.

Can some maintainer help me with the new test case? I need a file with permission to upload but not to download.
2018-10-20 00:55:01 +01:00
Michael Diarmid
6684d5e739 Merge pull request #1618 from invertase/database-fixes
[android][database] fix transactions issue in debugger #1503
2018-10-19 18:54:12 +01:00
Salakar
7face8662a [android][database] fix transactions issue in debugger #1503 2018-10-18 19:19:41 +01:00
Salakar
7cb42836e5 5.1.0-rc1 2018-10-17 19:44:37 +01:00
Salakar
1b538d800f [tests] update deps 2018-10-17 19:24:55 +01:00
Salakar
e4636b31d9 [android] remove fabric build tools from lib - only needed in client build.gradle 2018-10-17 19:24:24 +01:00
Michael Diarmid
cfe17e1085 Merge pull request #1604 from cmcewen/master
Update Fabric gradle plugin version
2018-10-16 19:56:27 +01:00
Salakar
d4946270c0 Merge remote-tracking branch 'origin/master' 2018-10-16 19:09:04 +01:00
Salakar
a087e562b7 [tests][ci][ios] switch to iPhone X simulator 2018-10-16 19:08:56 +01:00
Michael Diarmid
adcbeac3d1 Merge pull request #1605 from invertase/transactions-rework
Misc v5.1.0 changes
2018-10-16 19:00:49 +01:00
Connor McEwen
1679517138 Update Fabric gradle plugin version 2018-10-16 10:52:39 -07:00
Salakar
f43e56b10e fix regression caused by ffc2eca6da 2018-10-16 18:45:00 +01:00
Salakar
b4ac1ab7b0 [tests][ios] switch to iPhone X device type for detox 2018-10-16 18:16:45 +01:00
Salakar
f7b0acdada [tests][ios] misc firestore transactions 2018-10-16 18:15:18 +01:00
Salakar
4b8d840648 [ios][notifications] fix completion crash: #1576 2018-10-16 18:14:32 +01:00
Salakar
4b0486e58a [tests][ios] update podfile.lock 2018-10-15 20:38:38 +01:00
Salakar
5b8e9763c4 [ios][firestore] transactions re-work 2018-10-15 20:14:48 +01:00
Michael Diarmid
1b9273f409 Merge pull request #1580 from evelynccordner/patch-1
Fix typings to for `createShortDynamicLink`
2018-10-15 01:41:15 +01:00