kylefang/react-native-firebase
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-firebase.git synced 2026-01-12 22:50:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: disable direct channels API on iOS, fixes #3674 (#3733)

Browse Source 
* set shouldEstablishDirectChannel to NO

* tests: make `onMessage` test Android only

This test will no longer function on simulators as a direct message channel is no longer established.

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
This commit is contained in:
Tobias Lohse
2020-07-14 03:33:13 -05:00
committed by GitHub
parent 001cee0eac
commit 8c9f4f5e31
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/messaging/e2e/messaging.e2e.js
View File

@@ -171,7 +171,7 @@ describe('messaging()', () => {
}
});
it('receives messages when the app is in the foreground', async () => {
android.it('receives messages when the app is in the foreground', async () => {
const spy = sinon.spy();
const unsubscribe = firebase.messaging().onMessage(spy);
if (device.getPlatform() === 'ios') {

2
packages/messaging/ios/RNFBMessaging/RNFBMessaging+FIRMessagingDelegate.m
View File

@@ -40,7 +40,7 @@
dispatch_once(&once, ^{
RNFBMessagingFIRMessagingDelegate *strongSelf = weakSelf;
[FIRMessaging messaging].delegate = strongSelf;
[FIRMessaging messaging].shouldEstablishDirectChannel = YES;
[FIRMessaging messaging].shouldEstablishDirectChannel = NO;
});
}