kylefang/react-native-firebase
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-firebase.git synced 2026-01-12 22:50:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

[android] Utils.isAppInForeground not accounting for RN LifecycleState

Browse Source 
Prior to this change, this utility in some rare cases would return true that Activity was in the foreground, however, React Native was still in the process of resuming, this, for example, led to crashes in HeadlessJS Notification tasks: "Tried to start task RNFirebaseBackgroundMessage while in foreground, but this is not allowed."
This commit is contained in:
Michael Diarmid
2018-09-14 21:48:49 +01:00
committed by GitHub
parent 58d76d370f
commit 8a5aaa30b0
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
android/src/main/java/io/invertase/firebase/Utils.java
View File

@@ -9,6 +9,7 @@ import com.facebook.react.bridge.ReactContext;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.WritableMap;
import com.facebook.react.common.LifecycleState;
import com.facebook.react.modules.core.DeviceEventManagerModule;
import java.util.List;
@@ -151,7 +152,8 @@ public class Utils {
appProcess.importance == ActivityManager.RunningAppProcessInfo.IMPORTANCE_FOREGROUND
&& appProcess.processName.equals(packageName)
) {
return true;
ReactContext reactContext = (ReactContext) context;
return reactContext.getLifecycleState() == LifecycleState.RESUMED;
}
}