kylefang/react-native-firebase
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-firebase.git synced 2026-06-12 00:25:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(crashlytics): handle undefined fileName in stack frames (#3080)

Browse Source
This commit is contained in:
Michael Tamm
2020-01-13 18:23:32 +01:00
committed by Mike Diarmid
parent c5043d1fcf
commit 84be0ee2b2
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
packages/crashlytics/lib/handlers.js
View File

@@ -28,17 +28,22 @@ export function createNativeErrorObj(error, stackFrames, isUnhandledRejection) {
nativeObj.frames = [];
for (let i = 0; i < stackFrames.length; i++) {
const { columnNumber, lineNumber, fileName, functionName, source } = stackFrames[i];
const subStrLen = fileName.indexOf('?') < 0 ? fileName.length : fileName.indexOf('?');
const fileNameParsed =
fileName && fileName.length ? fileName.substring(0, subStrLen) : '<unknown>';
let fileNameParsed = '<unknown>';
if (fileName) {
const subStrLen = fileName.indexOf('?');
if (subStrLen < 0) {
fileNameParsed = fileName;
} else if (subStrLen > 0) {
fileNameParsed = fileName.substring(0, subStrLen);
}
}
nativeObj.frames.push({
src: source,
line: lineNumber || 0,
col: columnNumber || 0,
fn: functionName || '<unknown>',
file: `${fileNameParsed.length ? fileNameParsed : '<unknown>'}:${lineNumber ||
0}:${columnNumber || 0}`,
file: `${fileNameParsed}:${lineNumber || 0}:${columnNumber || 0}`,
});
}