kylefang/react-native-firebase
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-firebase.git synced 2026-04-13 09:38:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1479 from ecexplorer/master

Browse Source 
Guard against NPE in deleteChannelGroup
This commit is contained in:
Michael Diarmid
2018-09-10 20:38:23 +01:00
committed by GitHub
parent 02dfc7a1f9 48bf11849f
commit 217baffe2b
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
android/src/main/java/io/invertase/firebase/notifications/RNFirebaseNotifications.java
View File

@@ -176,8 +176,13 @@ public class RNFirebaseNotifications extends ReactContextBaseJavaModule implemen
@ReactMethod
public void deleteChannelGroup(String channelId, Promise promise) {
notificationManager.deleteChannelGroup(channelId);
promise.resolve(null);
try {
notificationManager.deleteChannelGroup(channelId);
promise.resolve(null);
} catch (NullPointerException e) {
promise.reject("notifications/channel-group-not-found",
"The requested NotificationChannelGroup does not exist, have you created it?");
}
}
@ReactMethod