kylefang/react-native-code-push
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-code-push.git synced 2026-05-09 07:08:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

[WPF] Fix application crash when storage file was deleted while app is being active. (#897)

Browse Source 
* Create file if non exist on each call

* Added asyn operation
This commit is contained in:
Alexander Bodalevsky
2017-06-22 14:53:23 +03:00
committed by Sergey Akhalkov
parent ef5ab894b1
commit fe9745237b
2 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Examples/CodePushDemoApp/windows/CodePushDemoApp/CodePushDemoApp.nuget.targets
View File

@@ -1,9 +0,0 @@
<?xml version="1.0" encoding="utf-8" standalone="no"?>
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup Condition="'$(NuGetPackageRoot)' == ''">
<NuGetPackageRoot>$(UserProfile)\.nuget\packages\</NuGetPackageRoot>
</PropertyGroup>
<ImportGroup>
<Import Project="$(NuGetPackageRoot)\Facebook.Yoga\1.0.1-pre\build\netstandard\Facebook.Yoga.targets" Condition="Exists('$(NuGetPackageRoot)\Facebook.Yoga\1.0.1-pre\build\netstandard\Facebook.Yoga.targets')" />
</ImportGroup>
</Project>

9
windows/CodePush.Net46/Adapters/Storage/ApplicationDataContainer.cs
View File

@@ -62,11 +62,12 @@ namespace CodePush.Net46.Adapters.Storage
private readonly SemaphoreSlim mutex = new SemaphoreSlim(1, 1);
const string STORAGE_NAME = "AppStorage.data";
IFile storageFile = null;
string storageFileName = null;
public ApplicationDataContainer(string name = STORAGE_NAME)
{
storageFile = FileSystem.Current.LocalStorage.CreateFileAsync(name, CreationCollisionOption.OpenIfExists).Result;
storageFileName = name;
var storageFile = FileSystem.Current.LocalStorage.CreateFileAsync(storageFileName, CreationCollisionOption.OpenIfExists).Result;
var data = CodePushUtils.GetJObjectFromFileAsync(storageFile).Result;
if (data != null)
@@ -90,6 +91,7 @@ namespace CodePush.Net46.Adapters.Storage
{
await mutex.WaitAsync().ConfigureAwait(false);
var jobject = JObject.FromObject(Values);
var storageFile = await FileSystem.Current.LocalStorage.CreateFileAsync(storageFileName, CreationCollisionOption.OpenIfExists).ConfigureAwait(false);
await storageFile.WriteAllTextAsync(JsonConvert.SerializeObject(jobject)).ConfigureAwait(false);
mutex.Release();
}
@@ -97,7 +99,8 @@ namespace CodePush.Net46.Adapters.Storage
public async Task DeleteAsync()
{
Values.Clear();
await storageFile.DeleteAsync();
var storageFile = await FileSystem.Current.LocalStorage.CreateFileAsync(storageFileName, CreationCollisionOption.OpenIfExists).ConfigureAwait(false);
await storageFile.DeleteAsync().ConfigureAwait(false);
}
}
}